experimental_createPersister fixed expiresAt instead of maxAge

[NicholasKuchiniski]

Hello, i work in finances and due to some compliance reasons, certain types of informations can only be cached until a given period, i'm trying to achieve that with experimental_createPersister and playing with the maxAge property, but i wasn't able to figure it out a way to do that using it.

Basically what i need is to persist the maxAge in the query and retrieve it when verifying if it is expired, this way, for example:

(Considering that i can only keep the information during the current day)

If i make a query at 23 pm, i would have 60 minutes of maxAge
If i make a query at 00:01, i would have 23 hours and 59 minutes of maxAge

The current implementation only allows me to define maxAge when creating the persister, so i can't do something like that, by the time someone tries to use the second query (00:01), the max age would be 23 hours and 59 minutes so the query made at 23pm would still be valid.

The idea i have is to persist the maxAge (which in my case i created another property inside the query metadata with the name expiresAt) inside the query and if this field is present, instead of relying on `maxAge. to determine if the query is expired or not, i would use it to compare the current date.

Another possible implementation would be to have a TTL in the query metadata so i can build this TTL in a query basis calculating how many time i have until the period where i want to consider the query expired (just like the TTL property works in Redis or DynamoDB, for example), then we just have to see how many time has passed between the query fetch and the current date, since the TTL would be persisted in the query itself, even if i am at a different day, since it would be relative to the current Date in the fetch moment, the query would still be invalidated since the number would be lower the closer i get to the date were i want to expiry the query in the cache.

I'm currently using this patch-package in my code to achieve that and it seems to be working:

diff --git a/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.cjs b/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.cjs
index f0b5b7c..f4197a5 100644
--- a/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.cjs
+++ b/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.cjs
@@ -45,7 +45,7 @@ function experimental_createPersister({
           const persistedQuery = await deserialize(storedData);
           if (persistedQuery.state.dataUpdatedAt) {
             const queryAge = Date.now() - persistedQuery.state.dataUpdatedAt;
-            const expired = queryAge > maxAge;
+            const expired = persistedQuery.meta?.expiresAt ? Date.now() > persistedQuery.meta.expiresAt : queryAge > maxAge;
             const busted = persistedQuery.buster !== buster;
             if (expired || busted) {
               await storage.removeItem(storageKey);
@@ -84,6 +84,7 @@ function experimental_createPersister({
             state: query.state,
             queryKey: query.queryKey,
             queryHash: query.queryHash,
+            meta: query.meta,
             buster
           })
         );
diff --git a/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.js b/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.js
index 1fb49e8..26ea63f 100644
--- a/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.js
+++ b/node_modules/@tanstack/query-persist-client-core/build/legacy/createPersister.js
@@ -20,7 +20,7 @@ function experimental_createPersister({
           const persistedQuery = await deserialize(storedData);
           if (persistedQuery.state.dataUpdatedAt) {
             const queryAge = Date.now() - persistedQuery.state.dataUpdatedAt;
-            const expired = queryAge > maxAge;
+            const expired = persistedQuery.meta?.expiresAt ? Date.now() > persistedQuery.meta.expiresAt : queryAge > maxAge;
             const busted = persistedQuery.buster !== buster;
             if (expired || busted) {
               await storage.removeItem(storageKey);
@@ -59,6 +59,7 @@ function experimental_createPersister({
             state: query.state,
             queryKey: query.queryKey,
             queryHash: query.queryHash,
+            meta: query.meta,
             buster
           })
         );

But i would like to hear of the community if this is something useful for the exprimental_createPersister