Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup browser is inaccessible with voiceover #83

Open
marrie opened this issue May 30, 2016 · 8 comments
Open

backup browser is inaccessible with voiceover #83

marrie opened this issue May 30, 2016 · 8 comments

Comments

@marrie
Copy link

marrie commented May 30, 2016

When a user wants to browse for files and they hit command O the backup browser is totally inaccessible to voiceover users. I personally cannot make heads or tales of this. QT I heard thugh has some accessibility issues with voiceove. Still though can this please be looked into?

Macbook air, 8 gigs of ram, , 256 gig ssd drive.. Os is El Capitan.

screenshot of backup browser

@gperciva gperciva self-assigned this May 30, 2016
@shinnok
Copy link
Contributor

shinnok commented May 31, 2016

marrie,

Thanks for reaching out to us. I'm trying to wrap my head around the Accessibility tools and techniques, so please be patient with me while I try to figure out how we can improve on this.

Quick question, can you navigate any of the ListViews in the application? These include the File Browser you posted, the Archives list and the Jobs list.

Another one, how can you read text that can't be focused on?

@marrie
Copy link
Author

marrie commented May 31, 2016

No actually I couldn't. There's some wonderful documentation at applevis.com I don't know where exactly on the site but there are wonderful articles, some linked from apple discussing voiceover. QT has had problems in apple and windows though. I know this as I use other clients with QT5 and even that has issues. I hope the QT devs fix those for all platforms of QT. Anyway I hope that helps someone. I'll look on applevis's site, unless someone beats me to it. This is a wonderful community of visually impaired people who would love to help you test.

@shinnok
Copy link
Contributor

shinnok commented Jun 6, 2016

Graham, after some investigation I think we might need to implement QAccessibleInterface, QAccessibleTableInterface for some of the custom widgets used in the FilePicker and Backup/Jobs list views in order to make them browsable/accessible via Voice Over. Testing/Improving Accessibility is quite the undertaking and I've only played with OS X so far. Here are the resources I found most useful so far:
http://doc.qt.io/qt-5/accessible.html
http://doc.qt.io/qt-5/accessible-qwidget.html
https://www.apple.com/voiceover/info/guide/

Besides the commonly agreed usability good practices like sticking to existing widgets, having descriptive tooltips&titles for every element, making sure focus is available for every action and in the proper order, etc.. going one step towards improving accessibility requires some planning. Can you please share your plan or insights you have so far in regards to handling this, since you've assigned both issues to yourself?

@gperciva
Copy link
Member

gperciva commented Jun 6, 2016

Certainly, but I'm leaving for BSDCan tomorrow so today I'm preparing my laptop and packing. I'll get back to you within a week.

@marrie
Copy link
Author

marrie commented Jun 6, 2016 via email

@shinnok
Copy link
Contributor

shinnok commented Jun 15, 2016

@marrie Do you think it would help if I would add 2 actions "Add File" and "Add Directory" to the system menu bar and keyboard shortcuts that pop the native Open File dialogs, as an interim solution at least? The reasons I don't have that and use only the custom File Browser are:

  1. You can't select both files and directories from the same dialog, thus the need for two separate actions;
  2. You can't select multiple directories at the same time;
  3. You can't control what's being displayed, in regards to hidden, system, symlink files;
    Every OS has a combination of those issues with the native dialogs, including OS X.

native-file-dialog-osx

@marrie
Copy link
Author

marrie commented Jun 15, 2016 via email

shinnok added a commit that referenced this issue Jun 20, 2016
For HID and Accesibility compliancy #83.
shinnok added a commit that referenced this issue Jun 21, 2016
Two separate actions have been added to the native menu bar and Backup list context menu:
* Add file(s)
* Add directory

Issue #83.
@shinnok
Copy link
Contributor

shinnok commented Jun 15, 2017

See comment #82 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants