From 309d31a5b1a84007708d41cbee88397b0f139aec Mon Sep 17 00:00:00 2001 From: leMaik Date: Thu, 1 Mar 2018 21:27:59 +0100 Subject: [PATCH] Add sideEffects to the package json for webpack 4. --- __tests__/testIcons.js | 2 -- __tests__/testPackage.js | 8 ++++++++ generate-module.js | 1 + package.json | 1 + 4 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 __tests__/testPackage.js diff --git a/__tests__/testIcons.js b/__tests__/testIcons.js index 2c84770..0251265 100644 --- a/__tests__/testIcons.js +++ b/__tests__/testIcons.js @@ -5,8 +5,6 @@ import MuiThemeProvider from 'material-ui/styles/MuiThemeProvider' import * as commonjsIcons from '../package/index' import * as es2015Icons from '../package/index.es' -console.log('hi') - describe('the generated commonjs module', () => { it('should export icons that render to SVGs', () => { for (const iconName of Object.keys(commonjsIcons)) { diff --git a/__tests__/testPackage.js b/__tests__/testPackage.js new file mode 100644 index 0000000..3ecc3a2 --- /dev/null +++ b/__tests__/testPackage.js @@ -0,0 +1,8 @@ +/* eslint-env jest */ + +describe('the npm package', () => { + it('should set sideEffects to false to allow webpack to optimize re-exports', () => { + const packageJson = require('../package/package.json') + expect(packageJson.sideEffects).toBe(false) + }) +}) diff --git a/generate-module.js b/generate-module.js index 8cbd708..1fd79dd 100755 --- a/generate-module.js +++ b/generate-module.js @@ -112,6 +112,7 @@ fse.writeFileSync(path.join(__dirname, 'package', 'package.json'), JSON.stringif 'main', 'module', 'jsnext:main', + 'sideEffects', 'repository', 'keywords', 'author', diff --git a/package.json b/package.json index 9b386ad..40e12d7 100644 --- a/package.json +++ b/package.json @@ -5,6 +5,7 @@ "main": "./index.js", "module": "./index.es.js", "jsnext:main": "./index.es.js", + "sideEffects": false, "repository": { "type": "git", "url": "git+https://github.com/TeamWertarbyte/mdi-material-ui.git"