Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: /iam command result is the opposite of the text response by the Bot #1075

Open
cotton105 opened this issue Jan 8, 2025 · 2 comments · Fixed by #1076
Open

[BUG]: /iam command result is the opposite of the text response by the Bot #1075

cotton105 opened this issue Jan 8, 2025 · 2 comments · Fixed by #1076
Labels
🐞 Bug Something isn't working with Bastion

Comments

@cotton105
Copy link

Describe the bug
If I use the /iam command to give me a role, the bot responds "I've removed you from the x role," but it actually adds it. Similarly, the bot responds "I've added you to the x role," when it actually removes it.

To Reproduce
Steps to reproduce the behavior:

  1. Run the /iam command with any configured role.
  2. See confusing message.

Screenshots
Running the command to give me the "Hell Let Loose Boys" role
image

Result of the command
image

Environment:

  • Bastion: v10.16
  • Operating System: Arch Linux (6.11.6-arch1-1)
@cotton105 cotton105 added the 🐞 Bug Something isn't working with Bastion label Jan 8, 2025
@atlanna Atlanna
Copy link

atlanna bot commented Jan 8, 2025

Thank you for opening this issue.
A maintainer will get by as soon as practical to address this issue.

Since this is your first time here, please check the contributing guidelines to see other ways you can get involved.

If this is a support question and not really an issue or suggestion, then please ask it in our Discord Server instead.

cotton105 added a commit to cotton105/Bastion that referenced this issue Jan 8, 2025
@cotton105
commands(iam): flip bot text response logic
0f37290 
Fixes: TheBastionBot#1075
@cotton105 cotton105 mentioned this issue Jan 8, 2025
Merged
2 tasks
@cotton105
Copy link
Author

The fix turned out to be trivial so I've submitted the above PR.

iamtraction added a commit that referenced this issue Jan 9, 2025
@iamtraction
commands(iam): flip bot text response logic (#1076)
7732e5f 
The `/iam` command responds with the reverse of the actual action taken
which can confuse the user. This change just flips the logic, so the
correct Locale string is used.

#### References
Fixes: #1075

#### Checklist
- [x] Documentation is changed or added (if applicable)
- [x] Commit message follows the [commit
guidelines](https://bastion.gitbook.io/docs/developers/contributing-guidelines/pulls#commit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Bug Something isn't working with Bastion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

commands(iam): flip bot text response logic cotton105/Bastion
1 participant
@cotton105