Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File formats documentation #132

Open
AlexandreDubray opened this issue Jun 9, 2023 · 1 comment
Open

File formats documentation #132

AlexandreDubray opened this issue Jun 9, 2023 · 1 comment

Comments

@AlexandreDubray
Copy link

Hello,

Unless I missed that part, it seems that there is no documentation (or pointers to external resources) on the formats supported to read probabilistic circuits from a file.
Altought the respective parser files gives a good idea on what is expected, it would be more practical (and beginner friendly !) to have a dedicated section in the documentation that explain how to format a file to represent a probabilistic circuits (or pointers to external resources for formats like psdd or spn).

@khosravipasha
Copy link
Contributor

khosravipasha commented Aug 2, 2023

The main formtat we use right now is using .jpc format. When you save a circuit to file it add a comment on top on how the file is formatted so you can check there.

We can also add that in the documentation website somewhere. We don't have any timelines on these changes, would be happy to accept a PR though.

https://github.com/Juice-jl/ProbabilisticCircuits.jl/blob/e531bb0804009990635509c8cae6d89e21cda7b7/src/io/jpc_io.jl#L159-L171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants