Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify unflatten, replace_value, and others #795

Open
mhauru opened this issue Feb 3, 2025 · 0 comments
Open

Unify unflatten, replace_value, and others #795

mhauru opened this issue Feb 3, 2025 · 0 comments

Comments

@mhauru
Copy link
Member

mhauru commented Feb 3, 2025

As noted in https://github.com/TuringLang/DynamicPPL.jl/pull/793/files#r1936255984 and the comment that it's on, unflatten, replace_value, one of the constructors for VarInfo, and set_values!! seem very similar, especially once indexing by samplers has been removed. Some or all of them should be unified into a single function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhauru