-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Enzyme on demo models / varinfos #813
Draft
penelopeysm
wants to merge
8
commits into
release-0.35
Choose a base branch
from
py/enzyme
base: release-0.35
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25b6c7e
to
a145999
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## py/no-ldp-ad #813 +/- ##
================================================
- Coverage 85.87% 3.98% -81.89%
================================================
Files 35 35
Lines 4205 4164 -41
================================================
- Hits 3611 166 -3445
- Misses 594 3998 +3404 ☔ View full report in Codecov by Sentry. |
a145999
to
cdbde76
Compare
0c57d37
to
570b493
Compare
f42a6e1
to
409fc3b
Compare
8f8018a
to
566257e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is highly speculative and will fail for many combinations of models / varinfos. The Enzyme tests also take literal hours to run so IMO this cannot be merged into main. I'm mainly opening this so that we can look at it.
In the long term I think a reasonable compromise might be to run Enzyme only on TypedVarInfo (or whatever DynamicPPL's default varinfo type is in the future).
Note: This PR also comments out all non-Enzyme AD tests