Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Enzyme on demo models / varinfos #813

Draft
wants to merge 8 commits into
base: release-0.35
Choose a base branch
from
Draft

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Feb 16, 2025

This is highly speculative and will fail for many combinations of models / varinfos. The Enzyme tests also take literal hours to run so IMO this cannot be merged into main. I'm mainly opening this so that we can look at it.

In the long term I think a reasonable compromise might be to run Enzyme only on TypedVarInfo (or whatever DynamicPPL's default varinfo type is in the future).

Note: This PR also comments out all non-Enzyme AD tests

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.98%. Comparing base (7060896) to head (409fc3b).

❗ There is a different number of reports uploaded between BASE (7060896) and HEAD (409fc3b). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (7060896) HEAD (409fc3b)
13 7
Additional details and impacted files
@@               Coverage Diff                @@
##           py/no-ldp-ad    #813       +/-   ##
================================================
- Coverage         85.87%   3.98%   -81.89%     
================================================
  Files                35      35               
  Lines              4205    4164       -41     
================================================
- Hits               3611     166     -3445     
- Misses              594    3998     +3404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm penelopeysm force-pushed the py/no-ldp-ad branch 2 times, most recently from 8f8018a to 566257e Compare February 18, 2025 22:23
Base automatically changed from py/no-ldp-ad to release-0.35 February 19, 2025 18:36
@yebai yebai mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant