-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] submodel explorations #815
Draft
penelopeysm
wants to merge
17
commits into
release-0.35
Choose a base branch
from
py/submodel
base: release-0.35
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a very minimalistic sketch of how to implement the original proposal in TuringLang/Turing.jl#2485:
Please see the tests for examples of its behaviour.
Note: If you'd like to discuss what syntax / features should be present please head over there :) please restrict comments on this PR to the 'how' i.e. the implementation
I have arbitrarily implemented the syntax in the original proposal because I had to have something to work with, and I like this. However, note that it's very likely that regardless of the form of the final user interface, a lot of the code changes here will be the same.
For example if we want to distinguish between to_sampleable (lhs is return value) and to_distribution (lhs is latents) then it's just a case of checking the wrapper type and changing the expression at the very end of
tilde_assume!!
such that the lhs is associated with the correct output. The rest of the newly added code intilde_assume!!
will remain the same, and the considerations of OrderedDict vs NamedTuple will remain the same.The main difference will lie in the DPPL compiler. The above syntax requires some small modifications to the compiler, whereas something like to_foo won't.
TODO
x.a
orx[1]
)condition
behaviourfix
behaviour