Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in a Lux extension? #40

Open
avik-pal opened this issue Sep 21, 2024 · 4 comments
Open

Interest in a Lux extension? #40

avik-pal opened this issue Sep 21, 2024 · 4 comments

Comments

@avik-pal
Copy link

The train_flow can be made to work with lux models with a hack. I am wondering if there is an interest in adding a native Lux version.

If there is interest from the maintainers, I can write an extension enabling that.

@sunxd3
Copy link
Member

sunxd3 commented Sep 22, 2024

Hi @avik-pal, thanks a lot for reaching out. We are absolutely interested, I'll work with you on this if you can start a PR.

@avik-pal
Copy link
Author

Awesome, I will get started on writing an initial version, and ping you once I have a minimal viable version.

@zuhengxu
Copy link
Member

zuhengxu commented Feb 16, 2025

Hi @avik-pal ,

Apologies for my silence mode for this issue!

Yes, we are super interested in integrating Lux. I saw the great lux tutorial for real nvp . So far the NormalizingFlow.jl interface basically assumes theflow object is a transformeddistribution via Bijectors.jl, and we can flatten the object to assess all parameters by destructuring (Optimiser.jl) it.

All of these constraints should be relaxed. I'll start working on this after refactoring the current code base a little bit, and to adapt the lux real nvp example with a more general interface.

@avik-pal
Copy link
Author

Thanks. This kind of fell off my radar.

We should also see if we can get Reactant to work with NormalizingFlows.jl, that will ensure a good performance when used with Lux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants