Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding Terradraw for sketch feature #2328

Closed
wants to merge 3 commits into from
Closed

feat: adding Terradraw for sketch feature #2328

wants to merge 3 commits into from

Conversation

JinIgarashi
Copy link
Contributor

@JinIgarashi JinIgarashi commented Nov 20, 2023 •
edited by sync-by-unito bot
Loading

Thank you for submitting a pull request!

Description

Closes #2325

I am trying to implement sketch feature by using terraDraw

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

┆Issue is synchronized with this Wrike task by Unito

@JinIgarashi JinIgarashi added the enhancement New feature or request label Nov 20, 2023
@JinIgarashi JinIgarashi self-assigned this Nov 20, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 907ce92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JinIgarashi JinIgarashi linked an issue Nov 21, 2023 that may be closed by this pull request
[FEATURE] implement sketching feature #2325
Open
2 tasks
@JinIgarashi JinIgarashi changed the title Feat/2325 scketch feat: adding Terradraw for sketch feature Nov 21, 2023
@JinIgarashi JinIgarashi mentioned this pull request Nov 22, 2023
Closed
@JinIgarashi
Copy link
Contributor Author

Let me close this. I am implementing terradraw plugin here.

https://github.com/watergis/maplibre-gl-terradraw

@JinIgarashi JinIgarashi closed this Sep 2, 2024
@JinIgarashi JinIgarashi deleted the feat/2325-scketch branch September 2, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JinIgarashi JinIgarashi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] implement sketching feature
1 participant
@JinIgarashi