Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SimpleSwap.sol Goerli tests and Deployments don't work #16

Open
EdwardsVO opened this issue Mar 7, 2023 · 0 comments
Open

Bug: SimpleSwap.sol Goerli tests and Deployments don't work #16

EdwardsVO opened this issue Mar 7, 2023 · 0 comments

Comments

@EdwardsVO
Copy link

EdwardsVO commented Mar 7, 2023

Error on Goerli Deployment

This SimpleSwap example work OK with the mainnet fork. But I find some bugs while deploying the SimpleSwap Contract on goerli testnet.

If you implement this on Goerli's testnet it won't work, WETH and DAI contracts don't live under these addresses, even if you update the contract addresses to the correct testnet ones neither tests nor deployments will work.

This is the output on the goerli fork node with both addresses versions (mainnet and testnet)

  • Error: Transaction reverted without a reason string

The Goerli addresses for these tokens are:

  • DAI = 0x4648a43B2C14Da09FdF82B161150d3F634f40491

  • WETH9 = 0xB4FBF271143F4FBf7B91A5ded31805e42b2208d6

Also i'm using this SwapRouter address:

  • 0xE592427A0AEce92De3Edee1F18E0157C05861564

This is the test error with both addresses updated (mainnet and testnet).
It is the same error with the mainnet addresses and node fork running on goerli

1) SimpleSwap Should provide a caller with more DAI than they started with after a swap: Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="balanceOf(address)", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.6.4)

Do you have any example with Goerli Testnet?

I need to deploy this contract on Goerli for some integration tests.
Any help will be really appreciate.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant