-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The mistake: wrong name for the train set and dev set for UP_Portuguese-Bosque #4
Comments
This issue is solved but many problems were found during the merge of the current UD data from the master branch of http://github.com/universaldependencies/UD_Portuguese-Bosque and the SRL annotations in the https://github.com/System-T/UniversalPropositions/tree/master/UP_Portuguese-Bosque. We will need to manually inspect some sentences and decide about the final format of the files in this repository. To make Portuguese data similar to the remain files, I will temporarily convert the new CoNLL-U valid files to CoNLL files (one extra column for each predicate). |
@huaiyu-zhu comments are welcome. |
I found at least one sentence in the current set of PT sentences in the MASTER branch with a wrong |
@arademaker Can we close this issue? Thanks. |
Hello @arademaker are you planning to merge branch |
Yes, I need to finish this issue. I will need 1-2 weeks for that. |
@arademaker Any updates? |
Sorry, I will solve it this week. But we still need to reevaluate the plans for the PR #7. |
UP |
Sorry, can you elaborate? |
@arademaker Sorry, I'm referring to the train and dev file naming problem. I only realized this after producing the dataset statistics. With my comment ("UP"), I wanted to bring to attention the fact that the names are still reversed. I take this opportunity to thank all of you for your work. Kind regards, |
You may wrongly named the train set file and dev set file for UP_Portuguese-Bosque by mistake.
The two file names need to be exchanged.
The text was updated successfully, but these errors were encountered: