Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDependencies bundled into Atmosphere package #32

Open
abernix opened this issue Dec 9, 2016 · 2 comments
Open

devDependencies bundled into Atmosphere package #32

abernix opened this issue Dec 9, 2016 · 2 comments

Comments

@abernix
Copy link

abernix commented Dec 9, 2016

As found in this forum post, it appears that angular-meteor-auth is suffering from the same issue as momentjs:[email protected] did in meteor/meteor#7958 where its devDependencies were packaged into the Atmosphere package, most likely because they were present in the directory when it was meteor publish'd?

This is making the package particularly large (11MB instead) and also preventing it from running on Windows (and probably Linux too) since the fsevents package is included.

$ ls -lh angular-meteor-auth-*.tgz
-rw-r--r--@ 1 jesse  staff   3.2K Dec  9 18:42 angular-meteor-auth-1.0.3-os+web.browser+web.cordova.tgz
-rw-r--r--@ 1 jesse  staff    11M Dec  9 18:42 angular-meteor-auth-1.1.0-os+web.browser+web.cordova.tgz
-rw-r--r--@ 1 jesse  staff    11M Dec  9 18:42 angular-meteor-auth-1.1.1-os+web.browser+web.cordova.tgz
$ ls -1 angular-meteor-auth-1.1.1/npm/node_modules/ | grep fsevents
fsevents

I think it just needs to be republished from a clean checkout. 😄

@aleksander351
Copy link

I was pulling my hair out... :)

@sean-stanley
Copy link

Couldn't deploy my app anymore after doing meteor update to get the latest accounts-facebook because angular-meteor-auth was breaking deployment on linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants