Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrubMachineName seems to get mixed up with ScrubUserName #1319

Open
bruno-garcia opened this issue Oct 14, 2024 · 3 comments
Open

ScrubMachineName seems to get mixed up with ScrubUserName #1319

bruno-garcia opened this issue Oct 14, 2024 · 3 comments

Comments

@bruno-garcia
Copy link

Describe the bug

In the Sentry .NET SDK repo, I opened a PR to change the GHA runner from ubuntu-latest to ubuntu-latest-4-cores.

A verify test on the Serilog tests fails (but not the other Integration tests):

-             ServerName: TheMachineName,
+             ServerName: TheUserName,

THe ServerName Scrubber: https://github.com/getsentry/sentry-dotnet/blob/edd0be43dc5d11f81dea765fca6aafdbad37a6f1/test/Sentry.Testing/VerifyExtensions.cs#L12C14-L12C30

Seems like that got mixed with the scrubber for UserName:

userNameReplacements = CreateWrappedReplacements(userName, "TheUserName");

No code change was done (as the diff shows), only the GHA runner changed.

We call the ignore code here:

https://github.com/getsentry/sentry-dotnet/blob/edd0be43dc5d11f81dea765fca6aafdbad37a6f1/test/Sentry.Serilog.Tests/IntegrationTests.verify.cs#L61C14-L61C41

Minimal Repro

Diff

Submit a PR that fixes the bug

Sorry I dunno what might be going on. Any insight appreciated.

@SimonCropp
Copy link
Member

thats a weird one. what do we get if the server and user name are not scrubbed?

@bruno-garcia
Copy link
Author

thats a weird one. what do we get if the server and user name are not scrubbed?

Not sure. I see you made a PR , thank you! Do you still need an answer for this? If so I can look it up

@bruno-garcia
Copy link
Author

Possibly related:

getsentry/sentry-unreal#658 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants