Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 Deprecations #525

Closed
crynobone opened this issue Nov 13, 2024 · 2 comments
Closed

PHP 8.4 Deprecations #525

crynobone opened this issue Nov 13, 2024 · 2 comments
Assignees
@SecondeJK
Labels
enhancement release-candidate This PR will result in a release work-scheduled This label indicates that the fix/resolution is scheduled into Vonage's workload

Comments

@crynobone
Copy link
Contributor

We are currently working on PHP 8.4 supports (release ETA November 21st, 2024) and found the following deprecation errors when trying to update laravel/vonage-notification-channel

Expected Behavior

Supports PHP 8.4

Current Behavior

1) /home/runner/work/vonage-notification-channel/vonage-notification-channel/vendor/vonage/client-core/src/Client.php:234
{closure:Vonage\Client::__construct():234}(): Implicitly marking parameter $errfile as nullable is deprecated, the explicit nullable type must be used instead

Triggered by:

* Illuminate\Notifications\Tests\Unit\Channels\VonageSmsChannelTest::testSmsIsSentViaVonage
  /home/runner/work/vonage-notification-channel/vonage-notification-channel/tests/Unit/Channels/VonageSmsChannelTest.php:20

2) /home/runner/work/vonage-notification-channel/vonage-notification-channel/vendor/vonage/client-core/src/Client.php:0
{closure:Vonage\Client::__construct():234}(): Implicitly marking parameter $errline as nullable is deprecated, the explicit nullable type must be used instead

Triggered by:

* Illuminate\Notifications\Tests\Unit\Channels\VonageSmsChannelTest::testSmsIsSentViaVonage
  /home/runner/work/vonage-notification-channel/vonage-notification-channel/tests/Unit/Channels/VonageSmsChannelTest.php:20

3) /home/runner/work/vonage-notification-channel/vonage-notification-channel/vendor/vonage/client-core/src/Client.php:0
{closure:Vonage\Client::__construct():234}(): Implicitly marking parameter $errorcontext as nullable is deprecated, the explicit nullable type must be used instead
@crynobone crynobone mentioned this issue Nov 13, 2024
Merged
2 tasks
@SecondeJK SecondeJK self-assigned this Nov 20, 2024
@SecondeJK
Copy link
Contributor

Incoming release

@SecondeJK SecondeJK added enhancement release-candidate This PR will result in a release work-scheduled This label indicates that the fix/resolution is scheduled into Vonage's workload labels Dec 4, 2024
@SecondeJK
Copy link
Contributor

Fixed in #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SecondeJK SecondeJK

Labels
enhancement release-candidate This PR will result in a release work-scheduled This label indicates that the fix/resolution is scheduled into Vonage's workload
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crynobone @SecondeJK