Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump links contain superflous unicode characters #328

Open
Zodiac1978 opened this issue May 16, 2021 · 7 comments
Open

Jump links contain superflous unicode characters #328

Zodiac1978 opened this issue May 16, 2021 · 7 comments

Comments

@Zodiac1978
Copy link

Zodiac1978 commented May 16, 2021

Simplify jump links by removing such characters

For example on https://wordpress.org/support/article/settings-discussion-screen/ we have these jump links:

https://wordpress.org/support/article/settings-discussion-screen/#email-me-whenever%ef%bb%bf
https://wordpress.org/support/article/settings-discussion-screen/#before-a-comment-appears%ef%bb%bf
https://wordpress.org/support/article/settings-discussion-screen/#comment-moderat%ef%bb%bfion%ef%bb%bf

Looks like this is a ZERO WIDTH NO-BREAK SPACE
https://www.fileformat.info/info/unicode/char/feff/index.htm

Also known as BOM: https://en.wikipedia.org/wiki/Byte_order_mark

I don't think it is useful or intended here and therefore should be removed to simplify those jump links.

I haven't checked any other pages, but maybe the problem is on more helphub pages.

@atachibana
Copy link
Collaborator

@Zodiac1978

These links in the TOC were automatically generated from the content by Plugin. The plugin generates the link based on the heading texts in the content. So, some lines must have those characters at the end of each line.

But, problem is those characters are invisible and no way to find it nor fix it.

For this article 'Settings Discussion Screen', I could remove those characters by re-typing heading lines and saving the document. I won't check every TOC, but 'll do the same things when I noticed those characters.

Thanks.

@Zodiac1978
Copy link
Author

Hi @atachibana

I think it would be a better approach to convert these spaces to normal ones in the TOC plugin instead of doing it manually.

All the best
Torsten

@atachibana atachibana reopened this Aug 24, 2021
@atachibana
Copy link
Collaborator

@Zodiac1978
Yes, it should be so.

@Kenshino
Do you know who is the owner of TOC plugin? We'd like to ask to modify

  • When it generates the link that includes '%ef%bb%bf' a the end of it, take it away.

@Kenshino
Copy link
Collaborator

Kenshino commented Sep 1, 2021

I think we built it.

@carl-alberto did it.

@carl-alberto
Copy link
Member

@atachibana feel free to modify, unfortunately I don't have bandwidth mo modify at the moment :(

@Zodiac1978
Copy link
Author

@carl-alberto @Kenshino If you point me to the correct location I can (hopefully) provide a patch to fix this in the plugin.

@Kenshino
Copy link
Collaborator

Kenshino commented Sep 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants