Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress Versions archive template #43

Closed
carl-alberto opened this issue Jul 12, 2016 · 7 comments
Closed

WordPress Versions archive template #43

carl-alberto opened this issue Jul 12, 2016 · 7 comments

Comments

@carl-alberto
Copy link
Member

No description provided.

@carl-alberto carl-alberto self-assigned this Jul 12, 2016
@carl-alberto
Copy link
Member Author

This will be a separate template file that have to call the related child terms for the major release term. Eg. 4.5 page has to call get_terms to get 4.5.1 4.5.2 etc

@Kenshino do you have sample posts that contains those terms that you mentioned?

@Kenshino
Copy link
Collaborator

WordPress Versions have already been migrated.

Do you mean those when you said sample posts?

@Kenshino Kenshino added this to the Version 1 milestone Jan 9, 2017
@atachibana atachibana self-assigned this Oct 12, 2017
@atachibana
Copy link
Collaborator

WordPress Versions Archive is the summary page of version information.
Already HelpHub defines custom post type for version document

Custom Post Type page
https://wp-helphub.com/wp-admin/edit.php?post_type=helphub_version

Example document.
https://wp-helphub.com/wordpress-version/version-4-5-2/

This issue expects summary pages that is similar to
https://codex.wordpress.org/WordPress_Versions

I will take this issue with help of #126 Archive.

@atachibana
Copy link
Collaborator

Version archive design.

  • Ordered by Major version from New to Old. (4.8 -> 4.7 -> 4.6 ...)
  • In each Major version, ordered by minor version from old to New (4.8.1 -> 4.8.2 -> 4.8.3 ...)

image

@Clorith Clorith modified the milestones: Version 1, Version 2 May 27, 2018
@Clorith Clorith removed the Phase 2 label May 27, 2018
@psaikali
Copy link

psaikali commented Jun 20, 2018

I'd be happy to help with that.

A couple of questions, to be sure the way I see this is the good way :

  1. We need to have 2 more meta fields for Changelog and Blog links, as we don't have them yet, is that correct ?
    capture 2018-06-20 a 17 34 26

  2. I'd rather work in the archive-helphub_version.php template file, as it feels "more native" to do so. Should we just hardcode the intro text in the template itself ?
    e81748ab3ac41531a91c4f6c51e5ffbc _capture 2018-06-20 a 17 37 20
    Otherwise we could have a specific page template for that page, and a metabox/field for the intro text, but I feel that this kind of flexibility is not needed right now ?

@atachibana
Copy link
Collaborator

@psaikali
Thank you for the support and your suggestions are definitely the same ones that I have :-)

  1. Yes. We should have additional fields as you say.

  2. I think we can hard code those statement in the template. As you say, no other parts will use it.

@atachibana
Copy link
Collaborator

@psaikali
As John said in the HelpHub meeting, I close this issue and opened new issue #246 under the Epic #249.
Please take the #246. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants