-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp-cli: combine two writeFile calles to one writeFiles step. #107
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Using above test link, Playground ran into theses errors:
@adamziel any idea what I am missing? |
returned to Tested again and it now works. |
@bph this looks like a bug to me. The files are added to the filesystem if I check with Could you please open an issue for this? |
I took another look at this @bph. Your original Blueprint created a directory with the name postcontent.md and added files named resource and url to the directory. This behavior matches our implementation of writeFile where a file can only be a literal value or another file tree (represented as a JSON object in the Blueprint). It would be mindblowing if we could append resource types like URLs in the way you attempted it, so it might be worth submitting a feature request to start a discussion. |
Thank you @bgrgicak for the sleuthing and encouragement. I added the feature request on the Playground repo |
Fixes #104