-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop assuming CLI stdout is a TTY write stream #2154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update is testing well. Output with TTY
Output without TTY
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Related to #2127
In WordPress/wordpress-playground, we still assume that the Playground CLI is running in a TTY context, and the CLI breaks when not in a TTY context because
process.stdout.clearLine()
andprocess.stdout.clearLine()
are missing.Here are some lines that fail without a TTY context:
wordpress-playground/packages/playground/cli/src/cli.ts
Lines 232 to 233 in f5b8539
Implementation details
This PR does a number of things:
run-commands
executor forplayground-cli:dev
should run in TTY mode.npx nx dev playground-cli
did seem to run in a TTY context.Testing Instructions (or ideally a Blueprint)
cd
into your Playground working dirtest-blueprint.json
in that directory based on this gist.rm -r ~/.wordpress-playground
to clear the Playground CLI cache.npx bun --watch ./packages/playground/cli/src/cli.ts server --blueprint=test-blueprint.json
rm -r ~/.wordpress-playground
to clear the Playground CLI cache.npx bun --watch ./packages/playground/cli/src/cli.ts server --blueprint=test-blueprint.json | more
more
causes the CLI's stdout to not be a TTY