Fix scp error in web app deployment #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
We're currently experiencing an scp error when attempting to transfer
mime-types.jsonas a single file to a the destination'~/website-deployment/'.https://github.com/WordPress/wordpress-playground/actions/runs/13481525026/job/37667340559#step:7:16325
It seems like the home dir resolution is failing altogether or inconsistent between scp and regular ssh login. This was working before. There may have been a change in the hosting environment that inadvertently affected this script.
The previous step copies a directory to the same destination, and that is working fine.
Implementation details
As a workaround, this PR just copies
mime-types.jsoninto the local directory that is successfully copied to the server. This way, the file is transferred to the same location, and we avoid this single-file weirdness with scp.Testing Instructions (or ideally a Blueprint)