-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid double anchor # in urls #21605
Comments
Hi @kkmuffme Thanks for using the Yoast SEO plugin and for creating an issue. I didn't find any issue with the settings loading of any settings page or causing any issues with having #top#import-seo or the jump links having two # anchors. So, I am closing this issue as it's not causing any issues to the plugin. |
https://datatracker.ietf.org/doc/html/rfc3986 The # symbol is used to introduce the fragment, and there is only one fragment component allowed, because the specification only allows one # followed by the fragment identifier. |
Hi @kkmuffme Thanks for sharing the details. I am re-opening this issue after consulting with our development team. What's next? |
Please give us a description of what happened
On some pages the URLs have a double anchor e.g. /wp-admin/admin.php?page=wpseo_tools&tool=import-export contains a
href="#top#import-seo"
To Reproduce
Step-by-step reproduction instructions
Expected results
Actual results
This bug can be seen in multiple files in the plugin, e.g. https://github.com/Yoast/wordpress-seo/blob/trunk/admin/class-admin.php#L244
Here's a list of files that have this issue I found with a quick grep:
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/class-admin.php
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/class-option-tabs-formatter.php
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/class-bulk-editor-list-table.php
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/views/tool-bulk-editor.php
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/views/tool-import-export.php
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/views/tabs/tool/wpseo-export.php
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/views/tabs/tool/wpseo-import.php
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/views/tabs/tool/import-seo.php
https://github.com/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/first-time-configuration-notice-integration.php
https://github.com/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/installation-success-integration.php
https://github.com/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/old-configuration-integration.php
https://github.com/Yoast/wordpress-seo/blob/trunk/src/integrations/admin/workouts-integration.php
The text was updated successfully, but these errors were encountered: