Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<main> element in ie10 #114

Open
lafeber opened this issue Aug 7, 2013 · 5 comments
Open

<main> element in ie10 #114

lafeber opened this issue Aug 7, 2013 · 5 comments

Comments

@lafeber
Copy link

lafeber commented Aug 7, 2013

The html5shiv makes sure the main element works as expected in ie8 and ie9. Awesome!

In ie10 however, it doesn't work at all (it gets completely ignored).

@Willem-Siebe
Copy link

Hi Lafeber, [EDIT ONE HOUR LATER]

I having issues with the main element as well, but my html5shiv was not updated to the new version yet, so the main element was not included yet. Also theme maker applied the script only for IE8 and lower, what ofcourse makes no sense if there are problems in IE10 with the main element. Actually the only thing that IE10 needs is that you have the main element displayed as a block element. So CSS would do the job here. But... the script aplies this CSS as well, and to be honest I did not have any problems like you had, it worked perfect.

The only browsers where the script did not work, where the folllowing mobile browsers:

iPhone > Chrome and Safari
Samsung Galaxy Note II > Standard Samsung browser

Is that normal? When I applied my own CSS to it (display: block;) this problem was solved.

Kind regards,

Willem

@lafeber
Copy link
Author

lafeber commented Sep 24, 2013

Even when you target IE10 it doesn't work. You can add

main {display:block} 

to your css to make it work though.

@Willem-Siebe
Copy link

Yes, I need that, but ONLY for my mobile browser problems, see this video I just made that html5shiv works perfect on IE10: http://screencast.com/t/NnKTBpzPY4w

@lafeber
Copy link
Author

lafeber commented Sep 24, 2013

It still doesn't work for me :) Via crossbrowsertesting.com, ie10 on Windows7. Then problem is that the top-margin of the main element is not picked up.

@Willem-Siebe
Copy link

Ok! I don't use a service like crossbrowsertesting.com yet, so I did not no IE10 on Windows 7 could act different then my IE10 on Windows 8. However, I targeted the html5shiv only to IE8 and lower again, because for IE9/10 and the mobile browsers the line display:block works as expected (although I did not test in on Windows 7!!) However, you also say this is working for you, so I'm confident my website displays correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants