Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiv not working in my site, what might be conflicting with it? #132

Open
maz123 opened this issue Nov 5, 2013 · 6 comments
Open

Shiv not working in my site, what might be conflicting with it? #132

maz123 opened this issue Nov 5, 2013 · 6 comments

Comments

@maz123
Copy link

maz123 commented Nov 5, 2013

Hi there, I have used the Shiv on my template and it's not working. Does anyone know of any conflicts that may cause it to stop working. I have included before the css, after the css, and that hasn't helped. I'm not sure what else to try...
Many Thanks in advance

http://tinyurl.com/q6kwovp

@dvorapa
Copy link

dvorapa commented Nov 5, 2013

You should include the shiv immediatelly after all included css and style tags. In your case you should include it immediately after this line of your code:

<!--[if IE 7]><link rel="stylesheet" href="css/font-awesome-ie7.min.css"><![endif]-->
<!--[if lt IE 9]><script type="text/javascript" src="js/html5shiv.js"></script><![endif]-->

@dvorapa
Copy link

dvorapa commented Nov 5, 2013

If you include it to this right place, it starts behave correctly in IE 9 and partly in IE 8 and lower. For that browsers, I recommend to look for unsupported CSS 3 features in IE 8 and lower, especially @media, advanced selectors and so on (see caniuse.com and try to polyfill some of them). I hope I'll help. Good luck with your project :-)

@maz123
Copy link
Author

maz123 commented Nov 6, 2013

After changing the placement of the shiv script it doesn't change how it shows in IE8 or 9? Also, I'm not sure if or why unsupported CSS3 is affecting this? maybe I've misunderstood you?

I think it may be something to do with the Dreamweaver templates... when I am attaching a template to a file, its putting this before the doc type declaration.

http://tinyurl.com/q6kwovp

Thanks for your help

@maz123
Copy link
Author

maz123 commented Nov 6, 2013

I'm using Modernizr so I am I right in saying that I shouldn't need a shiv, respond.js or css3-mediaqueries.js?

Any help muchly appreciated, really stumped! :-(

@dvorapa
Copy link

dvorapa commented Nov 6, 2013

I tried it and on my IE9 there it didn't work before replacement and it worked after replacement. And sorry, I didn't see the Modernizr. In my opinion there shouldn't be a problem with shiv, because Modernizr also includes the shiv as well, so it isn't necessary to load the second shiv (it could be your problem - two html5shivs!)... But I'm only the human, so I could be wrong. Don't be angry with me :-) I only try to help, but you code is so messy to me, and I don't want to immerse in details of your code...

@maz123
Copy link
Author

maz123 commented Nov 7, 2013

Oh no, I'm very sorry if my reply came across blunty, I really wasn't meaning it to be, I appreciate your responses.
I thought the Shiv in the Modernizr wasn't working so that why I tried putting in another... but it turns out that it does work, my problem lied in the media queries not working... I've added respond.js and now it's working... though I thought that was supposed to included with Modernizr aswell... very strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants