Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dependency check in scripts #100

Open
nylander opened this issue Jun 10, 2020 · 0 comments
Open

Skip dependency check in scripts #100

nylander opened this issue Jun 10, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@nylander
Copy link
Collaborator

The acetoscan script does a dependency check (lines 404--412):

### Checking dependencies

    echo -e "\n#\t${YELLOW}Performing dependencies check${RESTORE}"
    export PATH="/home/${user}/acetoscan/bin/:${PATH}"
    export PATH="/home/${user}/acetoscan/scripts/:${PATH}"

    # running check

    AcetoScan_software_check.sh # <= External script
  1. This check is done well after some output folders (and files) are created. That is, if the test fails, the user is left with a bunch of empty folders.
  2. The test also requires that the external script AcetoScan_software_check.sh is reachable from a hard coded path - which should be avoided (see issue Avoid creating folders in the install scripts #98)
  3. The export commands is basically an installation, and should be taken care of before running acetoscan - so is the check for necessary prerequisites.

I suggest skipping the test altogether. One may inform the user about the required software, and in a written instruction mention that there is a script ,AcetoScan_software_check.sh, that may hep the user to see what's missing before running the pipeline.

@abhijeetsingh1704 abhijeetsingh1704 added the enhancement New feature or request label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants