You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This check is done well after some output folders (and files) are created. That is, if the test fails, the user is left with a bunch of empty folders.
The test also requires that the external script AcetoScan_software_check.sh is reachable from a hard coded path - which should be avoided (see issue Avoid creating folders in the install scripts #98)
The export commands is basically an installation, and should be taken care of before running acetoscan - so is the check for necessary prerequisites.
I suggest skipping the test altogether. One may inform the user about the required software, and in a written instruction mention that there is a script ,AcetoScan_software_check.sh, that may hep the user to see what's missing before running the pipeline.
The text was updated successfully, but these errors were encountered:
The
acetoscan
script does a dependency check (lines 404--412):AcetoScan_software_check.sh
is reachable from a hard coded path - which should be avoided (see issue Avoid creating folders in the install scripts #98)export
commands is basically an installation, and should be taken care of before runningacetoscan
- so is the check for necessary prerequisites.I suggest skipping the test altogether. One may inform the user about the required software, and in a written instruction mention that there is a script ,
AcetoScan_software_check.sh
, that may hep the user to see what's missing before running the pipeline.The text was updated successfully, but these errors were encountered: