Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we have correct padding everywhere #14

Merged
merged 10 commits into from
Oct 30, 2024
Merged

Ensure we have correct padding everywhere #14

merged 10 commits into from
Oct 30, 2024

Conversation

adam-fowler
Copy link
Owner

No description provided.

@sebsto
Copy link

sebsto commented Oct 30, 2024

I just tested xcodeinstall against this branch, end-to-end, and it works for me.
Both the padding and the calculateSharedSecret with binary password allows to authenticate on Apple's SRP.

Thank you Adam

@adam-fowler
Copy link
Owner Author

@sebsto There are some more changes in this PR. Can you verify again.
You might need to change a couple of parameter names

@sebsto
Copy link

sebsto commented Oct 30, 2024

@adam-fowler thank you for the heads up I just test this branch with latest commit (9468111) and it still works for me.

@adam-fowler adam-fowler merged commit bd76e88 into main Oct 30, 2024
4 of 5 checks passed
@adam-fowler adam-fowler deleted the padding branch October 30, 2024 17:52
@abiligiri
Copy link

@adam-fowler thanks for these changes. Can you keep the public constructor for keypair? It will enable unit tests like these https://github.com/XcodesOrg/XcodesApp/blob/main/XcodesTests/AppStateUpdateTests.swift#L274 (specifically https://github.com/XcodesOrg/XcodesApp/blob/main/XcodesTests/AppStateUpdateTests.swift#L296)

@adam-fowler
Copy link
Owner Author

adam-fowler commented Nov 2, 2024

@adam-fowler thanks for these changes. Can you keep the public constructor for keypair? It will enable unit tests like these https://github.com/XcodesOrg/XcodesApp/blob/main/XcodesTests/AppStateUpdateTests.swift#L274 (specifically https://github.com/XcodesOrg/XcodesApp/blob/main/XcodesTests/AppStateUpdateTests.swift#L296)

The API has been re-designed to ensure we don't get bad values. If you still feel the need to re-test the library I guess I could use an @_spi(Testing) to make the symbol available for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants