-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we have correct padding everywhere #14
Conversation
I just tested xcodeinstall against this branch, end-to-end, and it works for me. Thank you Adam |
@sebsto There are some more changes in this PR. Can you verify again. |
@adam-fowler thank you for the heads up I just test this branch with latest commit (9468111) and it still works for me. |
@adam-fowler thanks for these changes. Can you keep the public constructor for keypair? It will enable unit tests like these https://github.com/XcodesOrg/XcodesApp/blob/main/XcodesTests/AppStateUpdateTests.swift#L274 (specifically https://github.com/XcodesOrg/XcodesApp/blob/main/XcodesTests/AppStateUpdateTests.swift#L296) |
The API has been re-designed to ensure we don't get bad values. If you still feel the need to re-test the library I guess I could use an |
No description provided.