Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md imports #28

Open
mrlem opened this issue Sep 7, 2020 · 0 comments
Open

README.md imports #28

mrlem opened this issue Sep 7, 2020 · 0 comments

Comments

@mrlem
Copy link

mrlem commented Sep 7, 2020

In the main README.md file, the imports seem a bit odd:

AndroidX Version

implementation 'com.snakydesign.livedataextensions:lives:1.3.0'
implementation 'android.arch.lifecycle:extensions:x.x.x' // If you are using the AndroidX version, that's fine too, as the Jetifier will take care of the conversion.

Non AndroidX Version

implementation 'com.snakydesign.livedataextensions:lives:1.2.1'
implementation 'androidx.lifecycle:lifecycle-livedata:x.x.x' 

Unless I'm mistaken, there's an inversion. The Non AndroidX Version should not import an androidx API.
Furthermore, shouldn't "androidx.lifecycle:lifecycle-livedata" read "androidx.lifecycle:lifecycle-livedata-ktx"? (not sure about this one, as I'm not sure I understand the reason behind those imports)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant