Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

Port setting breaks functionality #1

Open
williamjulianvicary opened this issue Aug 17, 2015 · 1 comment
Open

Port setting breaks functionality #1

williamjulianvicary opened this issue Aug 17, 2015 · 1 comment

Comments

@williamjulianvicary
Copy link

This line breaks functionality with connecting to SSL servers from a non-SSL connection:

i.e.
http://localhost - Connecting from
https://www.example.com - Connecting to

This sets the port to 80, when it should of course be 443!

Line 511 of src/AdvancedStore/Oauth2Client/Oauth2Client.php:
curl_setopt($ch, CURLOPT_PORT, $_SERVER['SERVER_PORT']);

Removing this line of code solved my issues, I can't see a reason why it would be needed given CURL can figure out the port auto-magically based on the protocol.

@JayJayOne
Copy link

Thank you for your input. I've fixed this. It actually didn't made much sense.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants