Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StableSwap] Issue 3: Fees, Incentives, and Yield Distribution #33

Open
polarker opened this issue Nov 15, 2024 · 16 comments
Open

[StableSwap] Issue 3: Fees, Incentives, and Yield Distribution #33

polarker opened this issue Nov 15, 2024 · 16 comments
Assignees
Labels

Comments

@polarker
Copy link
Member

Parent issue: #24

Objective:

Set up fee structures and yield distribution mechanisms for the StableSwap protocol.

Description:

This issue focuses on implementing swap fees, distributing them to liquidity providers, and calculating yields for LP tokens.

Tasks:

  1. Design a fee structure for trades performed in the pool.
  2. Implement adjustable parameters for swap fees.
  3. Develop logic to distribute collected fees to liquidity providers based on their share of the pool.
  4. Periodically calculate and update yields for LP tokens.
  5. Write tests to validate fee collection, distribution, and yield calculations.

Acceptance Criteria:

  • Swap fees are collected and distributed correctly to liquidity providers.
  • Fee parameters are adjustable without affecting ongoing operations.
  • Yields for LP tokens are calculated and updated periodically.
  • Tests ensure proper fee and yield management, including edge cases.
@polarker polarker changed the title [Stable Swap] Issue 3: Fees, Incentives, and Yield Distribution [StableSwap] Issue 3: Fees, Incentives, and Yield Distribution Nov 16, 2024
@mimisavage
Copy link

I'd like to handle this task.

@JoE11-y
Copy link

JoE11-y commented Nov 21, 2024

Can I work on this, please?

@ShantelPeters
Copy link

Would love to tackle this!

@Supa-mega
Copy link

Could I try solving this?

@petersdt
Copy link

I’d like to work on this.

@kfastov
Copy link
Collaborator

kfastov commented Nov 23, 2024

Hi, thank you for showing interest, this issue will be available after we get base code from #31

@abdegenius
Copy link

Can I tackle this one?

@CEOliam
Copy link

CEOliam commented Nov 25, 2024

Can I handle this task?

@aniruddhaaps
Copy link

To implement this issue I would setup a fee policy on the trades with adjustable parameters to provide flexibility. Build logic to proportionally apportion collected fees to liquidity providers and compute and update yields for LP tokens at regular periods. Functionality should be validated through comprehensive testing, where fee distribution and yield management are ensured to be correct.

@Jemiiah
Copy link

Jemiiah commented Nov 27, 2024

Hello @polarker @kfastov, i'm a fronend web3 developer who has made over 75+ contribution during past OD Hacks pls I would love to work on this issue, I can create a PR before 48 hours elapses

@Jemiiah
Copy link

Jemiiah commented Nov 28, 2024

Thank you for the assign.

This is dependent on #31 and #32.

@kfastov
Copy link
Collaborator

kfastov commented Nov 28, 2024

@Jemiiah Yep, you may coordinate with the guy who tackles #32, he already submitted draft PR, and maybe with #31 assignee too. I believe you can make the example boilerplate together without waiting 😄

@raduciobanu22
Copy link
Collaborator

@Jemiiah Yep, you may coordinate with the guy who tackles #32, he already submitted draft PR, and maybe with #31 assignee too. I believe you can make the example boilerplate together without waiting 😄

+1 @Jemiiah Are you still interested to work on this? If yes, feel free to continue without waiting. Otherwise I will reassign the issue to someone else.

@Jagadeeshftw
Copy link

Can I work on this, please?

@raduciobanu22
Copy link
Collaborator

@Jagadeeshftw Assigned it to you!

@Jagadeeshftw
Copy link

Thank you so much @raduciobanu22. I will start work on it immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests