Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual defect with the Modal on Android Action Sheet #22

Open
giantslogik opened this issue Nov 16, 2022 · 1 comment
Open

Visual defect with the Modal on Android Action Sheet #22

giantslogik opened this issue Nov 16, 2022 · 1 comment
Assignees
@alessiocancian
Labels
bug Something isn't working

Comments

@giantslogik
Copy link

Bug

Screenshot 2022-11-16 at 2 23 36 AM

Environment info

Library Version
@alessiocancian/react-native-actionsheet 3.1.3
react-native 0.69.7

Steps To Reproduce

  1. Setup the App to use translucent StatusBar
  2. Use the ActionSheet on Android.

Describe what you expected to happen:

  1. Expect the modal to go to the top of the screen. Instead it doesn't cover the StatusBar.

Proposed fix:
Allow setting the RN Modal statusBarTranslucent prop on ActionSheet . https://reactnative.dev/docs/modal#statusbartranslucent-android
@giantslogik giantslogik added the bug Something isn't working label Nov 16, 2022
@giantslogik giantslogik mentioned this issue Nov 16, 2022
Merged
@giantslogik
Copy link
Author

Here's a PR to fix this issue: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessiocancian alessiocancian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giantslogik @alessiocancian