Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

代码的上的一些异议 #12991

Open
dongyun-coder opened this issue Dec 25, 2024 · 3 comments
Open

代码的上的一些异议 #12991

dongyun-coder opened this issue Dec 25, 2024 · 3 comments

Comments

@dongyun-coder
Copy link

dongyun-coder commented Dec 25, 2024

  1. distro协议同步,当有未知的异常的时候,返回的code=200
    DistroDataRequestHandler#handle
 Loggers.DISTRO.error("[DISTRO-FAILED] distro handle with exception", e);
  DistroDataResponse result = new DistroDataResponse();
  result.setErrorCode(ResponseCode.FAIL.getCode());
  result.setMessage("handle distro request with exception");
  return result;

这里没有执行 result.setResultCode(500);

  1. ClientIpWhiteList.java 这个文件我看最新代码还有,好像没有地方使用,是不是废弃的。
@KomachiSion
Copy link
Collaborator

  1. 欢迎PR
  2. @shiyiyue1102 帮忙看下ClientIpWhiteList是否可以移除

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jan 10, 2025

ClientIpWhiteList 在nacos3.0中好像有被使用到, 所以先不移除了。

1的欢迎PR

@cnzakii
Copy link

cnzakii commented Jan 22, 2025

@KomachiSion

I am willing to fix issue 1, please assign it to me.

Additionally, clarify the fix method: when an exception is thrown, the ResponseCode should be set to FAIL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants