Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE#12994]Optimize config operation. #13002

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[ISSUE#12994]Optimize config operation. #13002

wants to merge 7 commits into from

Conversation

MatthewAden
Copy link
Contributor

What is the purpose of the change

its close #12994

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@github-actions GitHub Actions
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@wuyfee
Copy link

wuyfee commented Dec 30, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@MatthewAden MatthewAden marked this pull request as draft December 31, 2024 01:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.89474% with 42 lines in your changes missing coverage. Please review.

Project coverage is 72.45%. Comparing base (762303b) to head (83b5957).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
.../config/server/service/ConfigOperationService.java 7.14% 13 Missing ⚠️
...a/nacos/config/server/aspect/RequestLogAspect.java 77.08% 7 Missing and 4 partials ⚠️
...config/server/aspect/CapacityManagementAspect.java 85.00% 7 Missing and 2 partials ⚠️
...nacos/config/server/aspect/ConfigChangeAspect.java 87.50% 4 Missing and 2 partials ⚠️
...a/nacos/config/server/model/ConfigRequestInfo.java 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13002      +/-   ##
=============================================
+ Coverage      72.28%   72.45%   +0.17%     
- Complexity      9999    10022      +23     
=============================================
  Files           1309     1310       +1     
  Lines          41991    41993       +2     
  Branches        4405     4412       +7     
=============================================
+ Hits           30353    30426      +73     
+ Misses          9514     9443      -71     
  Partials        2124     2124
Files with missing lines Coverage Δ
...cos/config/server/controller/ConfigController.java 69.09% <100.00%> (-0.27%) ⬇️
...onfig/server/controller/v2/ConfigControllerV2.java 79.62% <100.00%> (+0.38%) ⬆️
...ba/nacos/config/server/monitor/MetricsMonitor.java 87.17% <ø> (+11.56%) ⬆️
...fig/server/remote/ConfigPublishRequestHandler.java 87.03% <100.00%> (+0.24%) ⬆️
...nfig/server/remote/ConfigRemoveRequestHandler.java 81.25% <100.00%> (+6.25%) ⬆️
...a/nacos/config/server/model/ConfigRequestInfo.java 48.48% <40.00%> (+0.20%) ⬆️
...nacos/config/server/aspect/ConfigChangeAspect.java 76.25% <87.50%> (-8.32%) ⬇️
...config/server/aspect/CapacityManagementAspect.java 68.39% <85.00%> (-1.61%) ⬇️
...a/nacos/config/server/aspect/RequestLogAspect.java 83.58% <77.08%> (+83.58%) ⬆️
.../config/server/service/ConfigOperationService.java 68.75% <7.14%> (-6.08%) ⬇️

... and 17 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762303b...83b5957. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Jan 1, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@MatthewAden MatthewAden marked this pull request as ready for review January 1, 2025 12:54
@wuyfee
Copy link

wuyfee commented Jan 1, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@MatthewAden MatthewAden marked this pull request as draft January 2, 2025 23:49
@Dario-s-j
Copy link

Dario-s-j commented Jan 3, 2025 via email

@shiyiyue1102
Copy link
Collaborator

shiyiyue1102 commented Jan 6, 2025 •
edited
Loading

change capacity aspect cutpoint to ConfigOperationService

@Dario-s-j
Copy link

Dario-s-j commented Jan 6, 2025 via email

@MatthewAden MatthewAden marked this pull request as ready for review January 10, 2025 02:34
@wuyfee
Copy link

wuyfee commented Jan 10, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
❌ - e2e-csharp-test (standalone & cluster): failure
❌ - e2e-nodejs-test (standalone & cluster): failure
❌ - e2e-python-test (standalone & cluster): failure
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Jan 10, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
❌ - e2e-csharp-test (standalone & cluster): failure
❌ - e2e-nodejs-test (standalone & cluster): failure
❌ - e2e-python-test (standalone & cluster): failure
✅ - clean (standalone & cluster & standalone_auth): success

@MatthewAden MatthewAden marked this pull request as draft January 10, 2025 05:48
@MatthewAden MatthewAden marked this pull request as ready for review January 10, 2025 06:22
@wuyfee
Copy link

wuyfee commented Jan 10, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
❌ - e2e-csharp-test (standalone & cluster): failure
❌ - e2e-nodejs-test (standalone & cluster): failure
❌ - e2e-python-test (standalone & cluster): failure
✅ - clean (standalone & cluster & standalone_auth): success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyiyue1102 shiyiyue1102 Awaiting requested review from shiyiyue1102

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server Config Operation Interface Refactor(Optimize)
5 participants
@MatthewAden @wuyfee @codecov-commenter @Dario-s-j @shiyiyue1102