Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE#13021] fix comment typo on ServiceInfo(key) constructor #13022

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ISSUE#13021] fix comment typo on ServiceInfo(key) constructor #13022

wants to merge 2 commits into from
+2 −2

Conversation

mawen12
Copy link

@mawen12 mawen12 commented Jan 8, 2025

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix comment typo on ServiceInfo(key) constructor

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (14becb8) to head (ee872f9).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13022      +/-   ##
=============================================
+ Coverage      72.28%   72.31%   +0.02%     
- Complexity     10000    10005       +5     
=============================================
  Files           1309     1309              
  Lines          41991    41993       +2     
  Branches        4405     4407       +2     
=============================================
+ Hits           30355    30368      +13     
+ Misses          9512     9500      -12     
- Partials        2124     2125       +1
Files with missing lines Coverage Δ
...com/alibaba/nacos/api/naming/pojo/ServiceInfo.java 93.25% <ø> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14becb8...ee872f9. Read the comment docs.

@KomachiSion KomachiSion linked an issue Jan 10, 2025 that may be closed by this pull request
fix comment typo on ServiceInfo #13021
Open
@KomachiSion KomachiSion added this to the 2.5.0 milestone Jan 10, 2025
@wuyfee
Copy link

wuyfee commented Jan 10, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
kind/code quality
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

fix comment typo on ServiceInfo
5 participants
@mawen12 @CLAassistant @codecov-commenter @wuyfee @KomachiSion