Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about configuration capacity management. #13034

Open
MatthewAden opened this issue Jan 12, 2025 · 2 comments
Open

Question about configuration capacity management. #13034

MatthewAden opened this issue Jan 12, 2025 · 2 comments
Labels
area/Config kind/discussion Category issues related to discussion

Comments

@MatthewAden
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The following is the description of tenants and groups on the official website:
image

According to the introduction on the official website, there can be multiple groups under one tenant. if there is a tenant named lisi with two groups, group1 and group2. At this time, when a configuration is inserted into group1 under tenant lisi, according to the logic of the current code, the capacity of the cluster +1 and the capacity of tenant lisi +1, but the capacity of group1 is not updated.

/**
* Usage counting service: it will count whether the limitation check function will be open.
*/
private void insertOrUpdateUsage(String group, String tenant, CounterMode counterMode, boolean hasTenant) {
try {
capacityService.insertAndUpdateClusterUsage(counterMode, true);
if (hasTenant) {
capacityService.insertAndUpdateTenantUsage(counterMode, tenant, true);
} else {
capacityService.insertAndUpdateGroupUsage(counterMode, group, true);
}
} catch (Exception e) {
LOGGER.error("[capacityManagement] insertOrUpdateUsage ", e);
}
}

Describe the solution you'd like
The capacity of the cluster +1. The capacity of tenant lisi +1. The capacity of group1 +1.

@KomachiSion
Copy link
Collaborator

There is an async task to update the capacity config, so the group1 capacity also will be update.

But there is an delay time for group level, which can be enhanced.

@KomachiSion KomachiSion added kind/discussion Category issues related to discussion area/Config labels Jan 13, 2025
@shiyiyue1102
Copy link
Collaborator

The current capacity protection mechanism controls the configuration of a non empty tenant at the tenant level and the configuration of an empty tenant at the group level, without controlling the group granularity of a non empty tenant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/discussion Category issues related to discussion
Projects
None yet
Development

No branches or pull requests

3 participants