From d89fc01f93f7686a42d267d154bd42f7b9336308 Mon Sep 17 00:00:00 2001
From: Emilia Hane <elsaemiliaevahane@gmail.com>
Date: Sun, 12 Jan 2025 19:29:14 +0100
Subject: [PATCH] chore(consensus): Replace magic numbers for tx type with
 constants (#1911)

Replace magic numbers for tx type with constants
---
 crates/consensus/src/transaction/mod.rs | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/crates/consensus/src/transaction/mod.rs b/crates/consensus/src/transaction/mod.rs
index 9e107740d7e..94269cd0ab5 100644
--- a/crates/consensus/src/transaction/mod.rs
+++ b/crates/consensus/src/transaction/mod.rs
@@ -1,6 +1,12 @@
 //! Transaction types.
 
-use crate::Signed;
+use crate::{
+    constants::{
+        EIP1559_TX_TYPE_ID, EIP2930_TX_TYPE_ID, EIP4844_TX_TYPE_ID, EIP7702_TX_TYPE_ID,
+        LEGACY_TX_TYPE_ID,
+    },
+    Signed,
+};
 use alloc::vec::Vec;
 use alloy_eips::{eip2930::AccessList, eip7702::SignedAuthorization};
 use alloy_primitives::{keccak256, Address, Bytes, ChainId, TxKind, B256, U256};
@@ -356,26 +362,26 @@ pub trait Typed2718 {
 
     /// Returns true if the type is a legacy transaction.
     fn is_legacy(&self) -> bool {
-        self.ty() == 0
+        self.ty() == LEGACY_TX_TYPE_ID
     }
 
     /// Returns true if the type is an EIP-2930 transaction.
     fn is_eip2930(&self) -> bool {
-        self.ty() == 1
+        self.ty() == EIP2930_TX_TYPE_ID
     }
 
     /// Returns true if the type is an EIP-1559 transaction.
     fn is_eip1559(&self) -> bool {
-        self.ty() == 2
+        self.ty() == EIP1559_TX_TYPE_ID
     }
 
     /// Returns true if the type is an EIP-4844 transaction.
     fn is_eip4844(&self) -> bool {
-        self.ty() == 3
+        self.ty() == EIP4844_TX_TYPE_ID
     }
 
     /// Returns true if the type is an EIP-7702 transaction.
     fn is_eip7702(&self) -> bool {
-        self.ty() == 4
+        self.ty() == EIP7702_TX_TYPE_ID
     }
 }