-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Change Filepicker #46
Comments
I don't think so. The file picker is the system one. As far as I know, there are not multiple system file pickers to choose from. We can't make our own, because by definition we would not have permission to see the filesystem.
This will probably never happen with the system file picker because the file would need to be parsed in order to show you the title, and the system will probably never have a built-in Org Mode parser.
Searching unopened files is possible, assuming the app has been given directory access permission. But I am not currently planning to work on such a thing.
Do I understand that you have everything working, it's just slow? For that I can only recommend either
|
I see, so I need to differentiate between the file picker and a file manager.
Then this sounds like a thing I could tackle. I'll have a look.
Yes, it just really slow. I checked again and it should work on my Ryzen 5 2600 with 16 GB RAM, so I'll have a look at the Android Developer docs. Thanks! |
I think it's a pretty big task: not only the actual searching itself (which will have to take place on the native side) but also how to present such a feature in the UI. I suggest the following steps:
I should also say that in order to continue publishing on the App Store I will require copyright assignment of any code contributions to myself. |
Oh wow. Thanks for the effort estimate and putting that into perspective.
If we see that it is feasible we can solve the copyright assignment. As long as the project is open source, I don't see a problem from my side with the assignment. |
I have seen mobile development on a PC with only 4 gigs of RAM, and it was a little awkward. To avoid OS-level freezes and crashes, you can avoid having a browser, IDE and emulator open. Even with a text editor and terminals open, you'll want to check how many Dart processes you have explicitly or implicitly spawned, each might be using a few hundred megs of RAM. If there are occasions where you really need to use an IDE and emulator, you can consider quitting out your browser until you're done with that task. Using software to monitor which apps or processes are using the most RAM may also help find contributors to the issue. |
With 16GB things should be tolerable assuming you don't have tons of other things running. I did just realize that there's an important point I forgot to mention: be sure to use an x86 system image for your AVD, not an ARM one. That really is night-and-day in terms of speed. |
I would like to close this ticket because changing the file picker is not feasible. Taking a second look at your other item:
I'm a bit confused: are you interested in searching for files, or searching in files? Because those are probably quite different. Could you open a new ticket explaining your proposal in more detail? |
I agree, and I wanted to suggest the same.
Searching for files by their |
Is it possible to change the filepicker when clicking on
+
?The stock filepicker is not the best one for finding
.org
files.Edit: Related to #18
On a sidenote: The drawback of a filepicker in general is that you cannot see the
#+TITLE
when searching.This makes searching for a file much more cumbersome compared to searching by document title, e.g. implemented in
org-roam
asorg-roam-find-file
I would like to contribute to this project but I have some troubles setting up Android Studio + Flutter + Emulator, especially performance wise. Do you have any resources/advice to make it easier?
The text was updated successfully, but these errors were encountered: