Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hcsshim.ProcessStat undefined issue #176

Conversation

KlwntSingh
Copy link

Description:

  1. Add windows build tag to fix building cw agent on Windows
  2. ran make goproto to fix PR checks

@lisguo
Copy link

lisguo commented Mar 1, 2024

It seems the integration-test check is failing

Error: ../../internal/kubelet/client.go:21:2: missing go.sum entry for module providing package github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/containerinsight (imported by github.com/open-telemetry/opentelemetry-collector-contrib/internal/kubelet); to add:

@KlwntSingh KlwntSingh requested a review from mxiamxia as a code owner March 1, 2024 17:48
lisguo
lisguo previously approved these changes Mar 1, 2024
@lisguo
Copy link

lisguo commented Mar 1, 2024

I see that lint is failing

make[2]: *** [../../Makefile.Common:155: checklicense] Error 1
make[1]: *** [Makefile:162: receiver/awscontainerinsightreceiver] Error 2

@KlwntSingh KlwntSingh changed the base branch from aws-cwa-dev to aws-cwa-ciwindows March 1, 2024 20:02
@KlwntSingh KlwntSingh requested a review from wangzlei as a code owner March 1, 2024 20:02
@KlwntSingh KlwntSingh changed the base branch from aws-cwa-ciwindows to aws-cwa-dev March 1, 2024 20:37
@KlwntSingh KlwntSingh closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants