Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstanceType to GPU metrics #185

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

movence
Copy link

@movence movence commented Mar 14, 2024

Description:
Add InstanceType attribute to GPU metrics

Testing:
Tested on a test cluster. Example EMF entry:

{
    "CloudWatchMetrics": [
        {
            "Namespace": "ContainerInsights",
            "Dimensions": [
                [
                    "ClusterName"
                ],
                [
                    "ClusterName",
                    "InstanceId",
                    "NodeName"
                ],
                [
                    "ClusterName",
                    "GpuDevice",
                    "InstanceId",
                    "InstanceType",
                    "NodeName"
                ]
            ],
            "Metrics": [
                {
                    "Name": "node_gpu_temperature",
                    "Unit": "None"
                },
                {
                    "Name": "node_gpu_power_draw",
                    "Unit": "None"
                },
                {
                    "Name": "node_gpu_utilization",
                    "Unit": "Percent"
                },
                {
                    "Name": "node_gpu_memory_utilization",
                    "Unit": "Percent"
                },
                {
                    "Name": "node_gpu_memory_used",
                    "Unit": "Bytes"
                },
                {
                    "Name": "node_gpu_memory_total",
                    "Unit": "Bytes"
                }
            ]
        }
    ],
    "ClusterName": "mixed-test",
    "GpuDevice": "nvidia0",
    "InstanceId": "i-xxxxxxxxxx",
    "InstanceType": "g4dn.xlarge",
    "NodeName": "ip-x-x-x-x.us-west-2.compute.internal",
    "OTelLib": "otelcol/prometheusreceiver",
    "Timestamp": "1710445148938",
    "Type": "NodeGPU",
    "Version": "0",
    "http.scheme": "https",
    "k8s.namespace.name": "amazon-cloudwatch",
    "kubernetes": {
        "host": "ip-x-x-x-x.us-west-2.compute.internal"
    },
    "net.host.name": "dcgm-exporter-service.amazon-cloudwatch.svc",
    "net.host.port": "9400",
    "service.instance.id": "dcgm-exporter-service.amazon-cloudwatch.svc:9400",
    "service.name": "containerInsightsDCGMExporterScraper",
    "node_gpu_memory_total": 16106127360,
    "node_gpu_memory_used": 198180864,
    "node_gpu_memory_utilization": 0.0007999999999999999,
    "node_gpu_power_draw": 33.199,
    "node_gpu_temperature": 31,
    "node_gpu_utilization": 9
}

jefchien
jefchien previously approved these changes Mar 14, 2024
@jefchien
Copy link

You'll need to fix the unit tests to accept the interface change.

straussb
straussb previously approved these changes Mar 14, 2024
@movence movence dismissed stale reviews from straussb and jefchien via 937b79e March 14, 2024 20:52
@movence movence merged commit 34bd73a into amazon-contributing:aws-cwa-dev Mar 14, 2024
48 of 67 checks passed
movence added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants