Minimal changeset for AD/MAX devices on latest OpenOCD master branch

[rhempel]

I raised an issue in the MSDK project regarding a possible port of the AD/MAX OpenOCD code to the latest OpenOCD master branch.

analogdevicesinc/msdk#1277

I have made some progress on this topic. I now have an OpenOCD from the upstream master branch with a minimal set of changes from the AD OpenOCD repo. The branch builds under MSYS2 UCRT on Windows and creates an executable that I can use to debug the MAX32690FTHR board.

There are probably a number of features that I have not ported over, mainly because I now have a "modern" version of OpenOCD that works for me for the MAX32xxx and ALL of the other Cortex M devices that I tend to use.

The current state (with a set of notes for building under MSYS2) is here:

https://github.com/rhempel/openocd/tree/adi-merge

Note, this is not by any means a pull request that OpenOCD is likely to take as-is. The commits should be broken down even further to make it clear what is changing, but I thought this would be better done by AD and of course I could assist if needed.

Feedback welcome.

[Brandon-Hurst]

Hi Ralph. First of all, thank you very much for looking at this. One thing I notice is that the adsp/ folder seems to be missing in https://github.com/rhempel/openocd/tree/adi-merge/src/flash/nor between your branch and the 0.12.0-1.1.1 tag. I get a couple trivial errors from this when it's included (building on WSL). Might need to look at fixing those.

Other than that, seems like de11f8 is the primary commit that would need to be broken up, and the rest of the commits appear fairly straightforward to me. Do you agree?

[andrew-mclachlan]

Tag @cwentwo @hmauadi

[rhempel]

@Brandon-Hurst Thanks for taking the time to look at this and point out the missing folder. I'll be happy to add it (maybe on the weekend).

I understand you folks have a series of build scrips as well for your CI system - I don't know if those should be included.

I have also built this branch unchanged under Ubuntu 22.4 and updated my notes accordingly with the required apt installs. Normally I build in a container for reproducibility.

Would it be helpful to have a brief call sometime to get organized? You can get my email fairly easily or just contact me on LinkedIn.

If we are going to do this I think the goal should be to get the changes into the upstream mainline - maybe someone on your team could contact the OpenOCD maintainer to get coordinated.

Side note: It took me two tries to get the port right. The first time I started doing diffs and got lost because I didn't know what was important.

The second time I started with adding the new state field to the arm5 struct and just kept adding only what was needed to get it to work.

It was actually not as bad as I thought it would be :-)