Increase resource limit comments/hints #430
Conversation
gnyahay
force-pushed
the
gn/bugfix/increase-resource-limits
branch
3 times, most recently
from
1abe4fd to
9eaf182
Compare
gnyahay
force-pushed
the
gn/bugfix/increase-resource-limits
branch
from
9eaf182 to
813c110
Compare
gnyahay
force-pushed
the
gn/bugfix/increase-resource-limits
branch
from
813c110 to
00f0819
Compare
gnyahay
force-pushed
the
gn/bugfix/increase-resource-limits
branch
from
00f0819 to
30878e8
Compare
There was a problem hiding this comment.
I appreciate the work here and like the intent of this, but I think our general approach for documenting best practices etc needs discussion around what is the right level of info in the values.yaml itself compared to other documentation that covers how to use the chart to achieve specific goals.
I agree the comments should be correct and any guidance we give shouldn't be inconsistent. I think there is more discussion on the specific values chosen, and the intent of those specific settings so we can review in that context.
| # memory: 8G | ||
| # limits: | ||
| # cpu: 2 |
There was a problem hiding this comment.
It seems that if we don't suggest setting CPU limits, then we shouldn't have them in here at all, just the requests.
There was a problem hiding this comment.
In cases where they are going to set them anyway I want to make sure they don't set it too low.
I am also hoping the BB chart follows our example: https://repo1.dso.mil/big-bang/product/packages/anchore-enterprise/-/blob/main/chart/values.yaml?ref_type=heads#L1444
| @@ -1012,6 +1019,7 @@ catalog: | |||
| ######################################################### | |||
| dataSyncer: | |||
| ## @param dataSyncer.replicaCount Number of replicas for the Anchore DataSyncer deployment | |||
| ## Please note that we do not suggest more than 1 instance of dataSyncer. | |||
There was a problem hiding this comment.
If we don't suggest this, should we remove this as a configurable option? I think we have to assume that while our comments should be correct, they won't be read nor followed.
There was a problem hiding this comment.
Yes please! @gnyahay @InfraInnovator @zhill - lets just remove the option
Signed-off-by: Greg Nyahay <[email protected]>
gnyahay
force-pushed
the
gn/bugfix/increase-resource-limits
branch
from
30878e8 to
b5c26f4
Compare
Provide more accurate comments/hints for resource requests & limits.