Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase resource limit comments/hints #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Increase resource limit comments/hints #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/enterprise/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: enterprise
version: "3.3.4"
version: "3.3.5"
appVersion: "5.13.1"
kubeVersion: 1.23.x - 1.31.x || 1.23.x-x - 1.31.x-x
description: |
Expand Down
52 changes: 38 additions & 14 deletions stable/enterprise/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,7 @@ anchoreConfig:
######################################################
analyzer:
## @param analyzer.replicaCount Number of replicas for the Anchore Analyzer deployment
## Please note that Anchore licensing may dictate the permitted number of analyzers.
##
replicaCount: 1

Expand All @@ -814,12 +815,14 @@ analyzer:
## @param analyzer.resources Resource requests and limits for Anchore Analyzer pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# cpu: 1
# cpu: 2
# memory: 8G
# limits:
# cpu: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that if we don't suggest setting CPU limits, then we shouldn't have them in here at all, just the requests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cases where they are going to set them anyway I want to make sure they don't set it too low.
I am also hoping the BB chart follows our example: https://repo1.dso.mil/big-bang/product/packages/anchore-enterprise/-/blob/main/chart/values.yaml?ref_type=heads#L1444

# memory: 8G

## @param analyzer.labels Labels for Anchore Analyzer pods
Expand Down Expand Up @@ -893,13 +896,15 @@ api:
## @param api.resources Resource requests and limits for Anchore API pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# cpu: 1
# memory: 4G
# cpu: 2
# memory: 8G
# limits:
# memory: 4G
# cpu: 4
# memory: 8G

## @param api.labels Labels for Anchore API pods
##
Expand Down Expand Up @@ -966,13 +971,15 @@ catalog:
## @param catalog.resources Resource requests and limits for Anchore Catalog pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# cpu: 2
# memory: 8G
# limits:
# memory: 8G
# cpu: 4
# memory: 12G

## @param catalog.labels Labels for Anchore Catalog pods
##
Expand Down Expand Up @@ -1012,6 +1019,7 @@ catalog:
#########################################################
dataSyncer:
## @param dataSyncer.replicaCount Number of replicas for the Anchore DataSyncer deployment
## Please note that we do not suggest more than 1 instance of dataSyncer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't suggest this, should we remove this as a configurable option? I think we have to assume that while our comments should be correct, they won't be read nor followed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! @gnyahay @InfraInnovator @zhill - lets just remove the option

##
replicaCount: 1

Expand Down Expand Up @@ -1051,6 +1059,7 @@ dataSyncer:
# cpu: 1
# memory: 8G
# limits:
# cpu: 2
# memory: 8G

## @param dataSyncer.labels Labels for Anchore DataSyncer pods
Expand Down Expand Up @@ -1091,6 +1100,7 @@ dataSyncer:
############################################
notifications:
## @param notifications.replicaCount Number of replicas for the Anchore Notifications deployment
## Please note that at this time only 1 instance of notifications can be active therefore we do not suggest more than 2.
##
replicaCount: 1

Expand Down Expand Up @@ -1124,12 +1134,14 @@ notifications:
## @param notifications.resources Resource requests and limits for Anchore Notifications pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# cpu: 1
# cpu: 2
# memory: 8G
# limits:
# cpu: 4
# memory: 8G

## @param notifications.labels Labels for Anchore Notifications pods
Expand Down Expand Up @@ -1198,13 +1210,15 @@ policyEngine:
## @param policyEngine.resources Resource requests and limits for Anchore Policy Engine pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# cpu: 2
# memory: 8G
# limits:
# memory: 8G
# cpu: 4
# memory: 12G

## @param policyEngine.labels Labels for Anchore Policy Engine pods
##
Expand Down Expand Up @@ -1277,14 +1291,16 @@ reports:
## @param reports.resources Resource requests and limits for Anchore Reports pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations
## Please note that we do not suggest setting CPU limits.
## NOTE: the commented resources below are assuming the use of a scratch volume with `anchoreConfig.reports.use_volume=true`
## If not using a scratch volume, the memory resources may need to be increased.
##
resources: {}
# requests:
# memory: 8G
# cpu: 1
# cpu: 2
# limits:
# cpu: 2
# memory: 8G

## @param reports.labels Labels for Anchore Reports pods
Expand Down Expand Up @@ -1368,12 +1384,14 @@ reportsWorker:
## @param reportsWorker.resources Resource requests and limits for Anchore Reports Worker pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# memory: 8G
# cpu: 2
# limits:
# cpu: 2
# memory: 8G

## @param reportsWorker.labels Labels for Anchore Reports Worker pods
Expand Down Expand Up @@ -1442,12 +1460,14 @@ simpleQueue:
## @param simpleQueue.resources Resource requests and limits for Anchore Simple Queue pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# cpu: 1
# cpu: 2
# memory: 8G
# limits:
# cpu: 4
# memory: 8G

## @param simpleQueue.labels Labels for Anchore Simple Queue pods
Expand Down Expand Up @@ -1536,13 +1556,15 @@ ui:
## @param ui.resources Resource requests and limits for Anchore UI pods
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
## Commented values below are just a suggested baseline. Contact Anchore support for deployment specific recommendations.
## Please note that we do not suggest setting CPU limits.
##
resources: {}
# requests:
# cpu: 1
# cpu: 2
# memory: 4G
# limits:
# memory: 4G
# cpu: 4
# memory: 8G

## @param ui.labels Labels for Anchore UI pods
##
Expand Down Expand Up @@ -1797,10 +1819,12 @@ postgresql:
## @param postgresql.primary.resources The resource limits & requests for the PostgreSQL Primary containers
##
resources: {}
# limits: {}
# limits:
# memory: 16G
# cpu: 4
# requests:
# memory: 512Mi
# cpu: 2
# memory: 16G
# cpu: 4

## @param postgresql.primary.service.ports.postgresql Port used to connect to Postgresql
##
Expand Down
Loading