remove user-agent and add tests for http header setting

syft/pkg/cataloger/rust/cataloger.go

@@ -4,23 +4,16 @@ Package rust provides a concrete Cataloger implementation relating to packages w
 package rust
 
 import (
-	"fmt"
-
 	"github.com/anchore/syft/internal/mimetype"
 	"github.com/anchore/syft/syft/pkg"
 	"github.com/anchore/syft/syft/pkg/cataloger/generic"
 )
 
 const (
-	toolName                      = "syft" // used for the user-agent string.
 	cargoAuditBinaryCatalogerName = "rust-cargo-auditable-binary-cataloger"
 	cargoLockCatalogerName        = "rust-cargo-lock-cataloger"
 )
 
-var (
-	userAgent = fmt.Sprintf("%s/%s", toolName, syftVersion())
-)
-
 // NewCargoLockCataloger returns a new Rust Cargo lock file cataloger object.
 func NewCargoLockCataloger(opts CatalogerConfig) pkg.Cataloger {
 	return generic.NewCataloger(cargoLockCatalogerName).

syft/pkg/cataloger/rust/crates_resolver.go

@@ -143,6 +143,5 @@ func newCratesLookupClient(opts CatalogerConfig) *http.Client {
 // to the values used when querying crates.io.
 func setHeaders(request *http.Request) *http.Request {
 	request.Header.Set("Accept", "application/json; charset=utf8")
-	request.Header.Set("User-Agent", userAgent)
 	return request
 }

syft/pkg/cataloger/rust/crates_resolver_test.go

@@ -1,6 +1,7 @@
 package rust
 
 import (
+	"net/http"
 	"os"
 	"testing"
 
@@ -52,3 +53,27 @@ func Test_parseCratesResponse(t *testing.T) {
 		})
 	}
 }
+
+func Test_setHeaders(t *testing.T) {
+	req, _ := http.NewRequest("GET", "http://foo/bar", nil)
+	type args struct {
+		request *http.Request
+	}
+	tests := []struct {
+		name string
+		args args
+	}{
+		{
+			name: "set header",
+			args: args{
+				request: req,
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := setHeaders(tt.args.request)
+			assert.Contains(t, got.Header, "Accept")
+		})
+	}
+}