fix: typed nils in cyclonedx #3680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
force-pushed
the
fix/cyclonedx-typed-nils
branch
from
da02df7 to
fb649fa
Compare
Signed-off-by: Keith Zantow <[email protected]>
kzantow
force-pushed
the
fix/cyclonedx-typed-nils
branch
from
fb649fa to
823723f
Compare
kzantow
commented
Feb 25, 2025
| components = append(components, cyclonedx.Component{ | ||
| BOMRef: string(coordinate.ID()), | ||
| Type: cyclonedx.ComponentTypeFile, | ||
| Name: metadata.Path, | ||
| Hashes: &cdxHashes, | ||
| Hashes: slicePtr(digestsToHashes(artifacts.FileDigests[coordinate])), |
There was a problem hiding this comment.
I've tried to add a test showing this fix working, but for some reason it doesn't have the same behavior as Grype. We are effectively running the same test in both, and in Syft it works as expected while in Grype it has a bug where a null value is output for "hashes". I've verified this specific fix corrects the issue in the Grype test, but I've very confused why there is different behavior.
Signed-off-by: Keith Zantow <[email protected]>
willmurphyscode
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where "typed nil" values are causing invalid cyclonedx to be generated with components containing
"hashes": null, which does not pass JSON validation.Type of change
Checklist: