Skip to content

Commit

Permalink
Update github actions
Browse files Browse the repository at this point in the history
Signed-off-by: Andrey Velichkevich <[email protected]>
  • Loading branch information
andreyvelich committed Feb 4, 2025
1 parent 06fab37 commit d94f73e
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 28 deletions.
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ body:
$ kubectl version
```
Training Operator version:
Kubeflow Trainer version:
```bash
$ kubectl get pods -n kubeflow -l control-plane=kubeflow-training-operator -o jsonpath="{.items[*].spec.containers[*].image}"
$ kubectl get pods -n kubeflow -l app.kubernetes.io/name=trainer -o jsonpath="{.items[*].spec.containers[*].image}"
```
Training Operator Python SDK version:
Kubeflow Python SDK version:
```bash
$ pip show kubeflow-training
$ pip show kubeflow
```
validations:
Expand Down
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!-- Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, check our contributor guidelines: https://www.kubeflow.org/docs/about/contributing
2. To know more about Training Operator, check the developer guide:
https://github.com/kubeflow/training-operator/blob/master/CONTRIBUTING.md
2. To know more about Kubeflow Trainer, check the developer guide:
https://github.com/kubeflow/trainer/blob/master/CONTRIBUTING.md
3. If you want *faster* PR reviews, check how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
-->

Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/build-and-push-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,37 +13,37 @@ jobs:
fail-fast: false
matrix:
include:
- component-name: training-operator-v2
dockerfile: cmd/training-operator.v2alpha1/Dockerfile
- component-name: trainer-controller-manager
dockerfile: cmd/trainer-controller-manager/Dockerfile
platforms: linux/amd64,linux/arm64,linux/ppc64le
tag-prefix: v2alpha1
- component-name: model-initializer-v2
dockerfile: cmd/initializer_v2/model/Dockerfile
tag-prefix: v1alpha1
- component-name: model-initializer
dockerfile: cmd/initializer/model/Dockerfile
platforms: linux/amd64,linux/arm64
tag-prefix: v2
- component-name: dataset-initializer-v2
dockerfile: cmd/initializer_v2/dataset/Dockerfile
tag-prefix: v1
- component-name: dataset-initializer
dockerfile: cmd/initializer/dataset/Dockerfile
platforms: linux/amd64,linux/arm64
tag-prefix: v2
tag-prefix: v1

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Docker Login
# Trigger workflow only for kubeflow/training-operator repository with specific branch (master, release-*) or tag (v.*).
# Trigger workflow only for kubeflow/trainer repository with specific branch (master, release-*) or tag (v.*).
if: >-
github.repository == 'kubeflow/training-operator' &&
github.repository == 'kubeflow/trainer' &&
(github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v'))
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Publish Component ${{ matrix.component-name }}
# Trigger workflow only for kubeflow/training-operator repository with specific branch (master, release-*) or tag (v.*).
# Trigger workflow only for kubeflow/trainer repository with specific branch (master, release-*) or tag (v.*).
if: >-
github.repository == 'kubeflow/training-operator' &&
github.repository == 'kubeflow/trainer' &&
(github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v'))
id: publish
uses: ./.github/workflows/template-publish-image
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ jobs:
- name: Install dependencies
run: |
echo "TODO (andreyvelich): Implement E2E Tests"
# pip install -U './sdk_v2'
# pip install -U './sdk'
14 changes: 7 additions & 7 deletions .github/workflows/test-go.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ jobs:
GOPATH: ${{ github.workspace }}/go
defaults:
run:
working-directory: ${{ env.GOPATH }}/src/github.com/kubeflow/training-operator
working-directory: ${{ env.GOPATH }}/src/github.com/kubeflow/trainer

steps:
- name: Checkout code
uses: actions/checkout@v4
with:
path: ${{ env.GOPATH }}/src/github.com/kubeflow/training-operator
path: ${{ env.GOPATH }}/src/github.com/kubeflow/trainer

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version-file: ${{ env.GOPATH }}/src/github.com/kubeflow/training-operator/go.mod
go-version-file: ${{ env.GOPATH }}/src/github.com/kubeflow/trainer/go.mod

- name: Check Go modules
run: |
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
GOPATH: ${{ github.workspace }}/go
defaults:
run:
working-directory: ${{ env.GOPATH }}/src/github.com/kubeflow/training-operator
working-directory: ${{ env.GOPATH }}/src/github.com/kubeflow/trainer

strategy:
fail-fast: false
Expand All @@ -63,12 +63,12 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4
with:
path: ${{ env.GOPATH }}/src/github.com/kubeflow/training-operator
path: ${{ env.GOPATH }}/src/github.com/kubeflow/trainer

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version-file: ${{ env.GOPATH }}/src/github.com/kubeflow/training-operator/go.mod
go-version-file: ${{ env.GOPATH }}/src/github.com/kubeflow/trainer/go.mod

- name: Run Go unit tests
run: |
Expand All @@ -82,5 +82,5 @@ jobs:
uses: shogo82148/actions-goveralls@v1
with:
path-to-profile: cover.out
working-directory: ${{ env.GOPATH }}/src/github.com/kubeflow/training-operator
working-directory: ${{ env.GOPATH }}/src/github.com/kubeflow/trainer
parallel: true
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ RUN --mount=type=cache,target=/go/pkg/mod/,sharing=locked \
go mod download
RUN --mount=type=cache,target=/go/pkg/mod/ \
--mount=type=bind,target=. \
CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -o /bin/manager cmd/trainer/main.go
CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -o /bin/manager cmd/trainer-controller-manager/main.go

# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
Expand Down
File renamed without changes.

0 comments on commit d94f73e

Please sign in to comment.