diff --git a/nodes/3.x/python/AngularDimension.ByElements.py b/nodes/3.x/python/AngularDimension.ByElements.py index 6f94cf95..7ab5a392 100644 --- a/nodes/3.x/python/AngularDimension.ByElements.py +++ b/nodes/3.x/python/AngularDimension.ByElements.py @@ -37,19 +37,4 @@ def CreateAngularDimension(view, items, arc, dimtype): TransactionManager.Instance.EnsureInTransaction(doc) OUT = [CreateAngularDimension(view, x, y, dimtype) for x, y in zip(items, arcs)] -TransactionManager.Instance.TransactionTaskDone() - -""" -TransactionManager.Instance.EnsureInTransaction(doc) -curvearray = CurveArray() -for curve in curves: - curvearray.Append(curve.ToRevitType()) -doccreation = doc.Create -separatorarray = doccreation.NewRoomBoundaryLines(sketchplane, curvearray, view) -TransactionManager.Instance.TransactionTaskDone() - -elementlist = list() -for item in separatorarray: - elementlist.append(item) -OUT = elementlist -""" \ No newline at end of file +TransactionManager.Instance.TransactionTaskDone() \ No newline at end of file diff --git a/nodes/3.x/python/Schedule.KeyScheduleParameterName.py b/nodes/3.x/python/Schedule.KeyScheduleParameterName.py index 44282af9..d9594f2b 100644 --- a/nodes/3.x/python/Schedule.KeyScheduleParameterName.py +++ b/nodes/3.x/python/Schedule.KeyScheduleParameterName.py @@ -3,8 +3,8 @@ from Autodesk.Revit.DB import * def GetKeyScheduleParamName(schedule): - if hasattr(schedule, "KeyScheduleParameterName"): return schedule.KeyScheduleParameterName - else: return None + try: return schedule.KeyScheduleParameterName + except: return None scheds = UnwrapElement(IN[0]) diff --git a/nodes/3.x/python/ScheduleField.Parameter.py b/nodes/3.x/python/ScheduleField.Parameter.py index 9c4af554..9b9c61d4 100644 --- a/nodes/3.x/python/ScheduleField.Parameter.py +++ b/nodes/3.x/python/ScheduleField.Parameter.py @@ -9,7 +9,7 @@ def GetScheduleFieldParam(schedulefield): if pId != ElementId.InvalidElementId: # BuiltInParameters if pId.IntegerValue < 0: - try: return bips[bipIds.index(pId.IntegerValue)] + try: return System.Enum.GetName(BuiltInParameter, pId.IntegerValue) except: return None # Project/Family/Shared Parameters else: return schedulefield.Schedule.Document.GetElement(schedulefield.ParameterId) @@ -17,14 +17,6 @@ def GetScheduleFieldParam(schedulefield): else: return None schedulefields = UnwrapElement(IN[0]) -bipsAll = System.Enum.GetValues(BuiltInParameter) -bips = [] -bipIds = [] -for bip in bipsAll: - try: - bips.append(bip) - bipIds.append(ElementId(bip).IntegerValue) - except: pass if isinstance(IN[0], list): OUT = [GetScheduleFieldParam(x) for x in schedulefields] else: OUT = GetScheduleFieldParam(schedulefields) \ No newline at end of file diff --git a/nodes/3.x/python/ScheduleField.Type.py b/nodes/3.x/python/ScheduleField.Type.py index adf31dd3..de59f3ab 100644 --- a/nodes/3.x/python/ScheduleField.Type.py +++ b/nodes/3.x/python/ScheduleField.Type.py @@ -1,9 +1,10 @@ import clr +import System clr.AddReference('RevitAPI') from Autodesk.Revit.DB import * def GetScheduleFieldType(field): - if hasattr(field, "FieldType"): return str(field.FieldType) + if hasattr(field, "FieldType"): return System.Enum.GetName(ScheduleFieldType, field.FieldType) else: return None if isinstance(IN[0], list): OUT = [GetScheduleFieldType(x) for x in IN[0]]