Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing how visits are counted #49

Open
mnskim opened this issue Jan 29, 2025 · 0 comments
Open

Fixing how visits are counted #49

mnskim opened this issue Jan 29, 2025 · 0 comments

Comments

@mnskim
Copy link
Contributor

mnskim commented Jan 29, 2025

Previously visits were only updated when calling backpropagation with a reward value,
@ #48 attempted to fix by always propagating values up independently from reward.

However this introduces a new bug of overcounting visits, because every time _backpropagate is called, all ancestor nodes get .visits +1.

I think it might be better to separate visit update from _backpropagate, there could be several options:

  • Visits could be updated when a node is selected, and the incrementing could be implemented in the BaseSelector class,
  • Alternatively, it could be updated in search_tree.py's _select function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant