-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt the user to create a password for accessing Grafana at install-time #24
Comments
Grafana's login page could potentially be removed if we add a global log-in screen for all BrainFrame services. |
Would we prompt for passwords for each service, or ask for a generic password and apply it to all the things? (Our customers might not know what Grafana is for example).
might yield a
I'm probably overthinking this though. Do we even need more than one password at the moment? |
Would we have to modify grafana's source for that? I think that may violate their AGPL license |
Looks like you can configure the Grafana username/password through configuration files |
@BryceBeagle Tyler is talking about a longer-term goal to have a separate service be our "log in" authenticator for all services in BrainFrame. I think that having grafana use our service for the login page may require a bit of code change with Grafana. |
Couldn't we do something fancy with nginx? If not authenticated, serve a different image with a login screen. If authenticated, serve the grafana image. |
Grafana has some support for delegating authorization to another service. I haven't looked into it too much though. |
I think at this point it's clear that we need a shared authorization service that lives on top of all of our other services. We would then want to turn off Grafana's authorization since it's redundant. Closing in favor of #30. |
This password will be stored to the
.env
file and used by BrainFrame's docker-compose.yml. This improves security as it prevents Grafana's default admin user from ever being publicly accessible.The text was updated successfully, but these errors were encountered: