[Feature][GitHub] allow filtering PRs.

[KyriosGN0]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Use case

we use renovate bot to open PRs to update packages, those PRs count towards our lead time for changes, which we found useless since pickup time can be high (if no one has time or just missed the PR)

Description

allow filtering by the Github plugins that it scans, preferably we would like to do it in the scope config

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[klesh]

Is it possible to filter them out directly in the SQL query from the Grafana dashboard?

[KyriosGN0]

@klesh it is possible to filter them in some dashboards that relay in the PR table, but the main DORA dashboard can't.

[karpanin]

Similar functionality is needed to filter bots when calculating pr_pickup_time metrics.

incubator-devlake/backend/plugins/dora/tasks/change_lead_time_calculator.go

Lines 183 to 207 in afcb66b

	func getFirstReview(prId string, prCreator string, db dal.Dal) (*code.PullRequestComment, errors.Error) {
	// Initialize a review comment object
	review := &code.PullRequestComment{}
	// Define the SQL clauses for the database query
	commentClauses := []dal.Clause{
	dal.From(&code.PullRequestComment{}), // Select from the "pull_request_comments" table
	dal.Where("pull_request_id = ? and account_id != ?", prId, prCreator), // Filter by the PR ID and exclude comments from the PR creator
	dal.Orderby("created_date ASC"), // Order by the created date of the review comments (ascending)
	}
	// Execute the query and retrieve the first review comment
	err := db.First(review, commentClauses...)
	// If any other error occurred, return nil and the error
	if err != nil {
	// If the error indicates that no review comment was found, return nil and no error
	if db.IsErrorNotFound(err) {
	return nil, nil
	}
	return nil, err
	}
	// If there were no errors, return the first review comment and no error
	return review, nil
	}

In the current implementation, the metric will be calculated from the first comment by the bot. We use Sonarqube and comments from sonarqube in Gitlab MR.

[klesh]

I see.
Maybe we could add an optional Environment Variable for the purpose.