[Bug][Azure Devops GO] Skipped pipeline tasks are being classified as FAILURE

[cs-grrolim]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

I had some pipelines being reported as PRODUCTION deployment on DORA charts even when the deployment tasks were skipped. (Actually, all tasks were skipped).
After investigating the source code, it was clear that tasks resulting in a skipped state were being classified as failures.

Screenshots available at: question

What do you expect to happen

Skipped tasks should not be classified as RESULT_DEFAULT not Failure, and be ignored when calculating metrics

How to reproduce

Create a deployment pipeline, add a task that is understood as deploymento to production with a condition that will fail.
Run the pipeline and verify that the task was skipped
When checking the DORA Validation dashboard, you can see the pipeline is marked as success with a production environment

Anything else

No response

Version

v1.0.1@e061ef2

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[dosubot]

The issue you're encountering seems to be related to how skipped tasks are classified in the Azure DevOps plugin of the DevLake codebase. Currently, skipped tasks are classified under the JobResult enumeration with the value Skipped, and in the conversion logic, they are mapped to devops.CICDResult.RESULT_DEFAULT ^[1][2]. This classification might be causing them to be interpreted incorrectly in the DORA metrics calculation, potentially leading to them being treated as failures.

To address this, you might consider modifying the logic that maps skipped tasks to ensure they are not classified as failures or included in the metrics calculation. This would involve adjusting the conversion logic to handle skipped tasks appropriately, possibly by excluding them from the metrics aggregation process.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other | Bug Report}

[cs-grrolim]

The behavior is different from the python plugin. The python plugin is ignoring the skipped stages