Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The alternative configuration method for setting the baseUrl is not setting on the link/url structure in sitemap.xml #40

Open
Darren-Caboz opened this issue Aug 5, 2020 · 0 comments
Labels

Comments

@Darren-Caboz
Copy link

To Reproduce

Step by step instructions to reproduce the behavior:

  1. Setting the baseUrl using the alternative configuration method as explain per guide: https://github.com/apostrophecms/apostrophe-site-map/#alternative-configuration
  2. Loading http://localhost:3000/sitemap.xml - The baseUrl is not showing on the links
  3. Have also run node app apostrophe-site-map:clear as well and reimplemented steps 1 and 2

Expected behavior

When applying the baseUrl in the 'apostrophe-site-map' as option, it should be include in the sitemap.xml generated as part of the links/url structure. For eg 0.9 daily http://localhost:3000/about-us

Describe the bug

When applying the baseUrl in the 'apostrophe-site-map' as option (as per https://github.com/apostrophecms/apostrophe-site-map/#alternative-configuration), it should be included in the sitemap.xml as part of the links/url structure.
for eg 0.9 daily /about-us

Details

Version of Node.js:
v8.11.4

Server Operating System:
MacOS Mojave

Additional context:

When using the main baseUrl configuration, it does prepend the baseUrl to the links/url in the sitemap.xml - for eg 0.9 daily http://localhost:3000/about-us

Xentropics added a commit to Xentropics/apostrophe-site-map that referenced this issue Oct 6, 2020
Added self.baseUrl to line 494 in index.js (bug apostrophecms#40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant