Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #598 Handle non-existent CRUD item with error and redirect #636

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ralfger
Copy link
Contributor

@ralfger ralfger commented Jan 30, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

This PR fixes an issue that happens when a user tries to access a CRUD item that doesn't exist. Now, instead of just failing, the app will:

  • Show a clear error message to let the user know the item isn't available.
  • Redirect the user back to the list of items to keep things running smoothly.

@ralfger ralfger requested a review from mkleszcz January 30, 2025 11:38
@ralfger ralfger linked an issue Jan 30, 2025 that may be closed by this pull request
5 tasks
@ralfger ralfger force-pushed the fix/non-existent-crud-item branch from f766e6d to 470ed56 Compare January 30, 2025 13:40
@ralfger ralfger changed the title fix: Handle non-existent CRUD item with error and redirect fix: #598 Handle non-existent CRUD item with error and redirect Jan 31, 2025
@ralfger ralfger requested a review from mkleszcz January 31, 2025 10:07
# Conflicts:
#	packages/webapp-libs/webapp-crud-demo/src/routes/crudDemoItem/crudDemoItemDetails/crudDemoItemDetails.component.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications redirect to not existing CRUD items
2 participants